From dde6ad495eede8de77fdbe67a0e75226b3322c19 Mon Sep 17 00:00:00 2001 From: Brian Tiger Chow Date: Mon, 15 Sep 2014 04:24:03 -0700 Subject: [PATCH] todo(blockservice, core) add notes * to wrap datastore for ease of use * to pass a non-responsive bitswap mock rather than performing nil * checks internally --- blockservice/blockservice.go | 2 ++ core/core.go | 2 ++ 2 files changed, 4 insertions(+) diff --git a/blockservice/blockservice.go b/blockservice/blockservice.go index 8f923c76b..8bd61a85d 100644 --- a/blockservice/blockservice.go +++ b/blockservice/blockservice.go @@ -35,6 +35,8 @@ func (s *BlockService) AddBlock(b *blocks.Block) (u.Key, error) { k := b.Key() dsk := ds.NewKey(string(k)) u.DOut("storing [%s] in datastore\n", k.Pretty()) + // TODO(brian): define a block datastore with a Put method which accepts a + // block parameter err := s.Datastore.Put(dsk, b.Data) if err != nil { return k, err diff --git a/core/core.go b/core/core.go index fe91ff8e8..d93c6f7b4 100644 --- a/core/core.go +++ b/core/core.go @@ -105,6 +105,8 @@ func NewIpfsNode(cfg *config.Config, online bool) (*IpfsNode, error) { go initConnections(cfg, route) } + // TODO(brian): when offline instantiate the BlockService with a bitswap + // session that simply doesn't return blocks bs, err := bserv.NewBlockService(d, bitswapSession) if err != nil { return nil, err