better daemon + main exit semantics

cmd/ipfs/daemon.go

@@ -158,27 +158,27 @@ func listenAndServeAPI(node *core.IpfsNode, req cmds.Request, addr ma.Multiaddr)
 	ifpsHandler := &ipfsHandler{node}
 	mux.Handle("/ipfs/", ifpsHandler)
 
-	done := make(chan struct{}, 1)
+	// if the server exits beforehand
-	defer func() {
+	var serverError error
-		done <- struct{}{}
+	serverExited := make(chan struct{})
-	}()
 
-	// go wait until the node dies
 	go func() {
-		select {
+		fmt.Printf("daemon listening on %s\n", addr)
-		case <-node.Closed():
+		serverError = server.ListenAndServe(host, mux)
-		case <-done:
+		close(serverExited)
-			return
-		}
-
-		log.Infof("terminating daemon at %s...", addr)
-		server.Shutdown <- true
 	}()
 
-	fmt.Printf("daemon listening on %s\n", addr)
+	// wait for server to exit.
-	if err := server.ListenAndServe(host, mux); err != nil {
+	select {
-		return err
+	case <-serverExited:
+
+	// if node being closed before server exits, close server
+	case <-node.Closing():
+		log.Infof("daemon at %s terminating...", addr)
+		server.Shutdown <- true
+		<-serverExited // now, DO wait until server exits
 	}
 
-	return nil
+	log.Infof("daemon at %s terminated", addr)
+	return serverError
 }

cmd/ipfs/main.go

@@ -490,25 +490,32 @@ func (i *cmdInvocation) setupInterruptHandler() {
 	sig := allInterruptSignals()
 
 	go func() {
+		// first time, try to shut down.
 
-		for {
+		// loop because we may be
-			// first time, try to shut down.
+		for count := 0; ; count++ {
 			<-sig
-			log.Critical("Received interrupt signal, shutting down...")
 
 			n, err := ctx.GetNode()
-			if err == nil {
+			if err != nil {
-				go n.Close()
+				log.Error(err)
-				select {
+				log.Critical("Received interrupt signal, terminating...")
-				case <-n.Closed():
+				os.Exit(-1)
-				case <-sig:
-					log.Critical("Received another interrupt signal, terminating...")
-				}
 			}
 
-			os.Exit(0)
+			switch count {
-		}
+			case 0:
+				log.Critical("Received interrupt signal, shutting down...")
+				go func() {
+					n.Close()
+					log.Info("Gracefully shut down.")
+				}()
 
+			default:
+				log.Critical("Received another interrupt before graceful shutdown, terminating...")
+				os.Exit(-1)
+			}
+		}
 	}()
 }