From c6ee2058d9a87b244cabfcc722f67ee85c2d26ed Mon Sep 17 00:00:00 2001 From: Jeromy Date: Fri, 17 Jul 2015 10:12:27 -0700 Subject: [PATCH] comments from CR License: MIT Signed-off-by: Jeromy --- Godeps/Godeps.json | 4 ---- blocks/blockstore/blockstore.go | 4 +++- core/corerouting/core.go | 2 +- routing/supernode/server.go | 4 ++-- 4 files changed, 6 insertions(+), 8 deletions(-) diff --git a/Godeps/Godeps.json b/Godeps/Godeps.json index 7b9cb1bf8..47ff2529b 100644 --- a/Godeps/Godeps.json +++ b/Godeps/Godeps.json @@ -166,11 +166,7 @@ }, { "ImportPath": "github.com/jbenet/go-datastore", -<<<<<<< HEAD "Rev": "c835c30f206c1e97172e428f052e225adab9abde" -======= - "Rev": "47af23f2ad09237ccc09c586c118048e2b39b358" ->>>>>>> fixup datastore interfaces }, { "ImportPath": "github.com/jbenet/go-detect-race", diff --git a/blocks/blockstore/blockstore.go b/blocks/blockstore/blockstore.go index e6a13cda6..bc000df93 100644 --- a/blocks/blockstore/blockstore.go +++ b/blocks/blockstore/blockstore.go @@ -52,9 +52,11 @@ type GCBlockstore interface { } func NewBlockstore(d ds.Batching) *blockstore { + var dsb ds.Batching dd := dsns.Wrap(d, BlockPrefix) + dsb = dd return &blockstore{ - datastore: dd, + datastore: dsb, } } diff --git a/core/corerouting/core.go b/core/corerouting/core.go index abe47f8ca..52f76a5c5 100644 --- a/core/corerouting/core.go +++ b/core/corerouting/core.go @@ -28,7 +28,7 @@ var ( // SupernodeServer returns a configuration for a routing server that stores // routing records to the provided datastore. Only routing records are store in // the datastore. -func SupernodeServer(recordSource ds.ThreadSafeDatastore) core.RoutingOption { +func SupernodeServer(recordSource ds.Datastore) core.RoutingOption { return func(ctx context.Context, ph host.Host, dstore repo.Datastore) (routing.IpfsRouting, error) { server, err := supernode.NewServer(recordSource, ph.Peerstore(), ph.ID()) if err != nil { diff --git a/routing/supernode/server.go b/routing/supernode/server.go index 97a5c832d..ab82ab5f1 100644 --- a/routing/supernode/server.go +++ b/routing/supernode/server.go @@ -18,13 +18,13 @@ import ( // Server handles routing queries using a database backend type Server struct { local peer.ID - routingBackend datastore.ThreadSafeDatastore + routingBackend datastore.Datastore peerstore peer.Peerstore *proxy.Loopback // so server can be injected into client } // NewServer creates a new Supernode routing Server -func NewServer(ds datastore.ThreadSafeDatastore, ps peer.Peerstore, local peer.ID) (*Server, error) { +func NewServer(ds datastore.Datastore, ps peer.Peerstore, local peer.ID) (*Server, error) { s := &Server{local, ds, ps, nil} s.Loopback = &proxy.Loopback{ Handler: s,