opensource/kubo
1
0
Fork 0
mirror of https://github.com/ipfs/kubo.git synced 2025-09-12 16:11:24 +08:00
Code Issues Projects Releases Wiki Activity

fix(bitswap): release the lock last

Browse Source 
The area above the lock was getting big. Moving this up to avoid
mistakes down the road.
This commit is contained in:
Brian Tiger Chow
2015-01-18 23:40:23 -08:00
parent df9e6ce640
commit aa4c0d1b90
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
exchange/bitswap/decision/engine.go
View File

@ -160,6 +160,9 @@ func (e *Engine) Peers() []peer.ID {
// MessageReceived performs book-keeping. Returns error if passed invalid // MessageReceived performs book-keeping. Returns error if passed invalid
// arguments. // arguments.
func (e *Engine) MessageReceived(p peer.ID, m bsmsg.BitSwapMessage) error { func (e *Engine) MessageReceived(p peer.ID, m bsmsg.BitSwapMessage) error {
e.lock.Lock()
defer e.lock.Unlock()
log := log.Prefix("bitswap.Engine.MessageReceived(%s)", p) log := log.Prefix("bitswap.Engine.MessageReceived(%s)", p)
log.Debugf("enter. %d entries %d blocks", len(m.Wantlist()), len(m.Blocks())) log.Debugf("enter. %d entries %d blocks", len(m.Wantlist()), len(m.Blocks()))
defer log.Debugf("exit") defer log.Debugf("exit")
@ -175,9 +178,6 @@ func (e *Engine) MessageReceived(p peer.ID, m bsmsg.BitSwapMessage) error {
} }
}() }()
e.lock.Lock()
defer e.lock.Unlock()
l := e.findOrCreate(p) l := e.findOrCreate(p)
if m.Full() { if m.Full() {
l.wantList = wl.New() l.wantList = wl.New()