From 914e653828b47c963cc15d3263f0f739380694a0 Mon Sep 17 00:00:00 2001 From: Steven Allen Date: Fri, 29 Dec 2017 13:00:24 -0800 Subject: [PATCH] only construct bitswap event loggable if necessary Base58 encoding cids/peerIDs isn't exactly fast. License: MIT Signed-off-by: Steven Allen --- exchange/bitswap/workers.go | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/exchange/bitswap/workers.go b/exchange/bitswap/workers.go index 00710d0af..8a1f420bd 100644 --- a/exchange/bitswap/workers.go +++ b/exchange/bitswap/workers.go @@ -59,11 +59,13 @@ func (bs *Bitswap) taskWorker(ctx context.Context, id int) { if !ok { continue } - log.Event(ctx, "Bitswap.TaskWorker.Work", logging.LoggableMap{ - "ID": id, - "Target": envelope.Peer.Pretty(), - "Block": envelope.Block.Cid().String(), - }) + log.Event(ctx, "Bitswap.TaskWorker.Work", logging.LoggableF(func() map[string]interface{} { + return logging.LoggableMap{ + "ID": id, + "Target": envelope.Peer.Pretty(), + "Block": envelope.Block.Cid().String(), + } + })) // update the BS ledger to reflect sent message // TODO: Should only track *useful* messages in ledger