opensource/kubo
1
0
Fork 0
mirror of https://github.com/ipfs/kubo.git synced 2025-08-06 11:31:54 +08:00
Code Issues Projects Releases Wiki Activity

commands: Moved argument checking into a Command method, fail early when parsing commands

Browse Source
This commit is contained in:
Matt Bell
2014-11-03 14:12:51 -08:00
committed by Juan Batiz-Benet
parent dbeffb6a0b
commit 75649f3d49
4 changed files with 60 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
commands/cli/parse.go
View File

@ -45,7 +45,14 @@ func Parse(input []string, roots ...*cmds.Command) (cmds.Request, *cmds.Command,
return nil, nil, err
}
return cmds.NewRequest(path, opts, args, cmd), root, nil
req := cmds.NewRequest(path, opts, args, cmd)
err = cmd.CheckArguments(req)
if err != nil {
return nil, nil, err
}
return req, root, nil
}
// parsePath gets the command path from the command line input
@ -108,8 +115,6 @@ func parseOptions(input []string) (map[string]interface{}, []string, error) {
return opts, args, nil
}
// Note that the argument handling here is dumb, it does not do any error-checking.
// (Arguments are further processed when the request is passed to the command to run)
func parseArgs(stringArgs []string, cmd *cmds.Command) ([]interface{}, error) {
var argDef cmds.Argument
args := make([]interface{}, len(stringArgs))