From 8663b4d48b7f00fe14d18518948222862a1fc17f Mon Sep 17 00:00:00 2001 From: Jesse Weinstein Date: Tue, 30 Aug 2016 18:31:53 -0700 Subject: [PATCH 1/3] Remove notice from list of log levels. This is because go-log does not support that level, although the underlying library, go-logging, does. License: MIT Signed-off-by: Jesse Weinstein --- core/commands/log.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/commands/log.go b/core/commands/log.go index 38552df22..e14d8d0b7 100644 --- a/core/commands/log.go +++ b/core/commands/log.go @@ -45,7 +45,7 @@ output of a running daemon. // clash with a subsystem name cmds.StringArg("subsystem", true, false, fmt.Sprintf("The subsystem logging identifier. Use '%s' for all subsystems.", logAllKeyword)), cmds.StringArg("level", true, false, `The log level, with 'debug' the most verbose and 'critical' the least verbose. - One of: debug, info, notice, warning, error, critical. + One of: debug, info, warning, error, critical. `), }, Run: func(req cmds.Request, res cmds.Response) { From 9304cf13db0df91ffb5a97945065423d4828a542 Mon Sep 17 00:00:00 2001 From: Jesse Weinstein Date: Tue, 30 Aug 2016 18:39:04 -0700 Subject: [PATCH 2/3] Clarify distinction between event and other logging License: MIT Signed-off-by: Jesse Weinstein --- core/commands/log.go | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/core/commands/log.go b/core/commands/log.go index e14d8d0b7..d62ae4ba7 100644 --- a/core/commands/log.go +++ b/core/commands/log.go @@ -35,8 +35,7 @@ var logLevelCmd = &cmds.Command{ Helptext: cmds.HelpText{ Tagline: "Change the logging level.", ShortDescription: ` -'ipfs log level' is a utility command used to change the logging -output of a running daemon. +Change the verbosity of one or all subsystems log output. Does NOT affect the event log. `, }, @@ -91,9 +90,9 @@ subsystems of a running daemon. var logTailCmd = &cmds.Command{ Helptext: cmds.HelpText{ - Tagline: "Read the logs.", + Tagline: "Read the event log.", ShortDescription: ` -'ipfs log tail' is a utility command used to read log output as it is written. +Outputs event log messages (NOT other log messages) as they are generated. `, }, From fab7ad8dd92c5d2554da4cdee591116ffc69dda3 Mon Sep 17 00:00:00 2001 From: Jesse Weinstein Date: Wed, 31 Aug 2016 21:59:43 -0700 Subject: [PATCH 3/3] Reduce vehemence of help text, per PR comments License: MIT Signed-off-by: Jesse Weinstein --- core/commands/log.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core/commands/log.go b/core/commands/log.go index d62ae4ba7..d5c1bbbfe 100644 --- a/core/commands/log.go +++ b/core/commands/log.go @@ -35,7 +35,7 @@ var logLevelCmd = &cmds.Command{ Helptext: cmds.HelpText{ Tagline: "Change the logging level.", ShortDescription: ` -Change the verbosity of one or all subsystems log output. Does NOT affect the event log. +Change the verbosity of one or all subsystems log output. This does not affect the event log. `, }, @@ -92,7 +92,7 @@ var logTailCmd = &cmds.Command{ Helptext: cmds.HelpText{ Tagline: "Read the event log.", ShortDescription: ` -Outputs event log messages (NOT other log messages) as they are generated. +Outputs event log messages (not other log messages) as they are generated. `, },