opensource/kubo
1
0
Fork 0
mirror of https://github.com/ipfs/kubo.git synced 2025-07-01 19:24:14 +08:00
Code Issues Projects Releases Wiki Activity

fix: ipfs get panic with empty API call

Browse Source 
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
This commit is contained in:
Jakub Sztandera
2017-03-08 16:48:05 +01:00
parent 0d6640434b
commit 66cc2f2e88
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
core/commands/get.go
View File

@ -51,6 +51,11 @@ may also specify the level of compression by specifying '-l=<1-9>'.
return err return err
}, },
Run: func(req cmds.Request, res cmds.Response) { Run: func(req cmds.Request, res cmds.Response) {
if len(req.Arguments()) == 0 {
res.SetError(errors.New("not enough arugments provided"), cmds.ErrClient)
return
}
cmplvl, err := getCompressOptions(req) cmplvl, err := getCompressOptions(req)
if err != nil { if err != nil {
res.SetError(err, cmds.ErrClient) res.SetError(err, cmds.ErrClient)

7
test/sharness/t0090-get.sh
View File

@ -154,6 +154,13 @@ test_get_fail
# should work online # should work online
test_launch_ipfs_daemon test_launch_ipfs_daemon
test_get_cmd test_get_cmd
test_expect_success "empty request to get doesn't panic and returns error" '
curl "http://$API_ADDR/api/v0/get" > curl_out || true &&
grep "not enough arugments provided" curl_out
'
test_kill_ipfs_daemon test_kill_ipfs_daemon
test_done test_done