opensource/kubo
1
0
Fork 0
mirror of https://github.com/ipfs/kubo.git synced 2025-07-02 03:28:25 +08:00
Code Issues Projects Releases Wiki Activity

parse_test: improve existing tests

Browse Source 
License: MIT
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
This commit is contained in:
Christian Couder
2015-05-03 20:10:28 +02:00
parent c6dcfaaf5d
commit 47a88f8429
1 changed files with 29 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

80
commands/cli/parse_test.go
View File

@ -158,28 +158,37 @@ func TestArgumentParsing(t *testing.T) {
}, },
} }
_, _, _, err := Parse([]string{"noarg"}, nil, rootCmd) test := func(cmd words, f *os.File, res words) {
if err != nil { if f != nil {
t.Error("Should have passed") if _, err := f.Seek(0, os.SEEK_SET); err != nil {
t.Fatal(err)
} }
_, _, _, err = Parse([]string{"noarg", "value!"}, nil, rootCmd) }
req, _, _, err := Parse(cmd, f, rootCmd)
if err != nil {
t.Errorf("Command '%v' should have passed parsing", cmd)
}
if !sameWords(req.Arguments(), res) {
t.Errorf("Arguments parsed from '%v' are not '%v'", cmd, res)
}
}
test([]string{"noarg"}, nil, []string{})
_, _, _, err := Parse([]string{"noarg", "value!"}, nil, rootCmd)
if err == nil { if err == nil {
t.Error("Should have failed (provided an arg, but command didn't define any)") t.Error("Should have failed (provided an arg, but command didn't define any)")
} }
_, _, _, err = Parse([]string{"onearg", "value!"}, nil, rootCmd) test([]string{"onearg", "value!"}, nil, []string{"value!"})
if err != nil {
t.Error("Should have passed")
}
_, _, _, err = Parse([]string{"onearg"}, nil, rootCmd) _, _, _, err = Parse([]string{"onearg"}, nil, rootCmd)
if err == nil { if err == nil {
t.Error("Should have failed (didn't provide any args, arg is required)") t.Error("Should have failed (didn't provide any args, arg is required)")
} }
_, _, _, err = Parse([]string{"twoargs", "value1", "value2"}, nil, rootCmd) test([]string{"twoargs", "value1", "value2"}, nil, []string{"value1", "value2"})
if err != nil {
t.Error("Should have passed")
}
_, _, _, err = Parse([]string{"twoargs", "value!"}, nil, rootCmd) _, _, _, err = Parse([]string{"twoargs", "value!"}, nil, rootCmd)
if err == nil { if err == nil {
t.Error("Should have failed (only provided 1 arg, needs 2)") t.Error("Should have failed (only provided 1 arg, needs 2)")
@ -189,36 +198,20 @@ func TestArgumentParsing(t *testing.T) {
t.Error("Should have failed (didn't provide any args, 2 required)") t.Error("Should have failed (didn't provide any args, 2 required)")
} }
_, _, _, err = Parse([]string{"variadic", "value!"}, nil, rootCmd) test([]string{"variadic", "value!"}, nil, []string{"value!"})
if err != nil { test([]string{"variadic", "value1", "value2", "value3"}, nil, []string{"value1", "value2", "value3"})
t.Error("Should have passed")
}
_, _, _, err = Parse([]string{"variadic", "value1", "value2", "value3"}, nil, rootCmd)
if err != nil {
t.Error("Should have passed")
}
_, _, _, err = Parse([]string{"variadic"}, nil, rootCmd) _, _, _, err = Parse([]string{"variadic"}, nil, rootCmd)
if err == nil { if err == nil {
t.Error("Should have failed (didn't provide any args, 1 required)") t.Error("Should have failed (didn't provide any args, 1 required)")
} }
_, _, _, err = Parse([]string{"optional", "value!"}, nil, rootCmd) test([]string{"optional", "value!"}, nil, []string{"value!"})
if err != nil { test([]string{"optional"}, nil, []string{})
t.Error("Should have passed")
} test([]string{"reversedoptional", "value1", "value2"}, nil, []string{"value1", "value2"})
_, _, _, err = Parse([]string{"optional"}, nil, rootCmd) test([]string{"reversedoptional", "value!"}, nil, []string{"value!"})
if err != nil {
t.Error("Should have passed")
}
_, _, _, err = Parse([]string{"reversedoptional", "value1", "value2"}, nil, rootCmd)
if err != nil {
t.Error("Should have passed")
}
_, _, _, err = Parse([]string{"reversedoptional", "value!"}, nil, rootCmd)
if err != nil {
t.Error("Should have passed")
}
_, _, _, err = Parse([]string{"reversedoptional"}, nil, rootCmd) _, _, _, err = Parse([]string{"reversedoptional"}, nil, rootCmd)
if err == nil { if err == nil {
t.Error("Should have failed (didn't provide any args, 1 required)") t.Error("Should have failed (didn't provide any args, 1 required)")
@ -242,21 +235,6 @@ func TestArgumentParsing(t *testing.T) {
return fstdin return fstdin
} }
test := func(cmd words, f *os.File, res words) {
if f != nil {
if _, err := f.Seek(0, os.SEEK_SET); err != nil {
t.Fatal(err)
}
}
req, _, _, err := Parse(cmd, f, rootCmd)
if err != nil {
t.Error("Command '%v' should have passed parsing", cmd)
}
if !sameWords(req.Arguments(), res) {
t.Errorf("Arguments parsed from '%v' are not '%v'", cmd, res)
}
}
test([]string{"stdinenabled", "value1", "value2"}, nil, []string{"value1", "value2"}) test([]string{"stdinenabled", "value1", "value2"}, nil, []string{"value1", "value2"})
fstdin := fileToSimulateStdin(t, "stdin1") fstdin := fileToSimulateStdin(t, "stdin1")