refactor: if statement (#10105)

core/commands/dag/dag.go

@@ -234,10 +234,10 @@ Specification of CAR formats: https://ipld.io/specs/transport/car/
 
 			if event.Root.PinErrorMsg != "" {
 				return fmt.Errorf("pinning root %q FAILED: %s", enc.Encode(event.Root.Cid), event.Root.PinErrorMsg)
-			} else {
-				event.Root.PinErrorMsg = "success"
 			}
 
+			event.Root.PinErrorMsg = "success"
+
 			_, err = fmt.Fprintf(
 				w,
 				"Pinned root\t%s\t%s\n",

core/corehttp/option_test.go

@@ -51,11 +51,10 @@ func TestCheckVersionOption(t *testing.T) {
 			called = true
 			if !tc.shouldHandle {
 				t.Error("handler was called even though version didn't match")
-			} else {
+			}
 			if _, err := io.WriteString(w, "check!"); err != nil {
 				t.Error(err)
 			}
-			}
 		})
 
 		w := httptest.NewRecorder()

core/corehttp/routing.go

@@ -100,10 +100,9 @@ func (it *peerChanIter) Next() bool {
 	if ok {
 		it.next = &addr
 		return true
-	} else {
+	}
 	it.next = nil
 	return false
-	}
 }
 
 func (it *peerChanIter) Val() types.Record {

core/node/libp2p/smux.go

@@ -38,7 +38,7 @@ func makeSmuxTransportOption(tptConfig config.Transports) (libp2p.Option, error)
 			}
 		}
 		return libp2p.ChainOptions(opts...), nil
-	} else {
+	}
 	return prioritizeOptions([]priorityOption{{
 		priority:        tptConfig.Multiplexers.Yamux,
 		defaultPriority: 100,
@@ -48,7 +48,6 @@ func makeSmuxTransportOption(tptConfig config.Transports) (libp2p.Option, error)
 		defaultPriority: config.Disabled,
 		opt:             libp2p.Muxer(mplex.ID, mplex.DefaultTransport),
 	}}), nil
-	}
 }
 
 func SmuxTransport(tptConfig config.Transports) func() (opts Libp2pOpts, err error) {

fuse/node/mount_darwin.go

@@ -141,9 +141,8 @@ func darwinFuseCheckVersion(node *core.IpfsNode) error {
 			return err
 		} else if skip {
 			return nil // user told us not to check version... ok....
-		} else {
-			return errGFV
 		}
+		return errGFV
 	}
 
 	log.Debug("mount: osxfuse version:", ov)