opensource/json-server
1
0
Fork 0
mirror of https://github.com/typicode/json-server.git synced 2025-08-02 02:53:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

Update DELETE to return 404 if resource doesn't exist

Browse Source
This commit is contained in:
Typicode
2015-10-13 21:55:14 +02:00
parent 4be2f30fdb
commit 94cfbabd41
2 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/server/router/plural.js
View File

@ -230,7 +230,7 @@ module.exports = function (db, name) {
// DELETE /name/:id
function destroy (req, res, next) {
db(name).removeById(utils.toNative(req.params.id))
var resource = db(name).removeById(utils.toNative(req.params.id))
// Remove dependents documents
var removable = db._.getRemovable(db.object)
@ -239,7 +239,10 @@ module.exports = function (db, name) {
db(item.name).removeById(item.id)
})
if (resource) {
res.locals.data = {}
}
next()
}

8
test/server/plural.js
View File

@ -474,6 +474,14 @@ describe('Server', function () {
done()
})
})
it('should respond with 404 if resource is not found', function (done) {
request(server)
.del('/posts/9001')
.expect('Content-Type', /json/)
.expect({})
.expect(404, done)
})
})
describe('Static routes', function () {