From 68b3b0fafb2edb5fd203e555dbeca8dc254cfaaa Mon Sep 17 00:00:00 2001 From: Jameel Moses Date: Thu, 2 Nov 2017 17:13:42 -0400 Subject: [PATCH] moving logger after express.static to prevent unnecessary logging of static files with express (#587) --- src/server/defaults.js | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/server/defaults.js b/src/server/defaults.js index 00e1466..2e65a9e 100644 --- a/src/server/defaults.js +++ b/src/server/defaults.js @@ -22,16 +22,6 @@ module.exports = function(opts) { arr.push(compression()) } - // Logger - if (opts.logger) { - arr.push( - logger('dev', { - skip: req => - process.env.NODE_ENV === 'test' || req.path === '/favicon.ico' - }) - ) - } - // Enable CORS for all the requests, including static files if (!opts.noCors) { arr.push(cors({ origin: true, credentials: true })) @@ -45,6 +35,16 @@ module.exports = function(opts) { // Serve static files arr.push(express.static(opts.static)) + // Logger + if (opts.logger) { + arr.push( + logger('dev', { + skip: req => + process.env.NODE_ENV === 'test' || req.path === '/favicon.ico' + }) + ) + } + // No cache for IE // https://support.microsoft.com/en-us/kb/234067 arr.push((req, res, next) => {