1114 Commits

Author SHA1 Message Date
07d3de883f Update Server.Stop docs per code review comments from grpc/grpc-go#540 2016-02-09 23:50:03 +00:00
af41c9cc8e Merge pull request #540 from iamqizhao/master
refine the comments of grpc.Server.Stop()
2016-02-09 15:38:37 -08:00
854ad3492a refine the comments of grpc.Server.Stop() 2016-02-09 15:22:53 -08:00
e390a33099 Merge pull request #538 from iamqizhao/master
Improve an error message
2016-02-09 11:31:51 -08:00
e000b83ffb Improve an error message 2016-02-09 11:16:47 -08:00
36d0fa20a1 Merge pull request #535 from iamqizhao/master
Close ServerTransport instead of the raw connection
2016-02-08 17:06:23 -08:00
6079240b2c remove fail_on_leak flag 2016-02-08 14:50:27 -08:00
77ccaa8fb2 Close ServerTransport instead of the raw connection 2016-02-08 14:27:06 -08:00
16885aa34b Merge pull request #529 from bradfitz/leaks
Fix test-only goroutine leaks; add leak checker to end2end tests.
2016-02-08 10:51:53 -08:00
fc0c458b89 Fix test-only goroutine leaks; add leak checker to end2end tests.
Some leaks remain, so this is disabled for now.

Updates grpc/grpc-go#528
2016-02-08 15:03:15 +00:00
933601d8cd Merge pull request #527 from tamird/regen-protos
`make proto`
2016-02-05 10:43:27 -08:00
accbf4c185 make proto 2016-02-04 17:35:04 -05:00
66b94b9f6b Merge pull request #525 from ejona86/sync-proto
Sync example protos from main repository
2016-02-03 16:46:24 -08:00
d3c0f79fa5 Sync example protos from main repository
grpc/grpc-java#1381
2016-02-03 10:14:35 -08:00
5d64098b94 Merge pull request #517 from zellyn/zellyn-grpclog-comments
Comment: explain concurrent access to grpclog.logger
2016-02-01 13:55:10 -08:00
fbb51f41f2 Merge pull request #518 from bradfitz/fatalf2
Fix more cases of Fatalf being used from goroutines started by tests.
2016-02-01 13:54:57 -08:00
d52370625d Fix more cases of Fatalf being used from goroutines started by tests.
Follow-up to #515 based on comments there from @maniksurtani.
2016-02-01 21:01:14 +00:00
a0f854fec2 Merge pull request #515 from bradfitz/fatalf
Don't call t.FailNow in goroutines started by tests.
2016-02-01 12:50:34 -08:00
65e7361599 Comment: explain concurrent access to grpclog.logger
grpc's pluggable logger is not mutex-protected: added comments that it
should be changed only in init() functions.
2016-02-01 15:07:17 -05:00
8024a575aa Don't call t.FailNow in goroutines started by tests.
The docs at https://golang.org/pkg/testing/#T.FailNow say:

> FailNow must be called from the goroutine running the test or
> benchmark function, not from other goroutines created during the
> test.

(Fatalf is documented as "Fatalf is equivalent to Logf followed by
FailNow.")

This was manifesting itself as a race with two concurrently failing
goroutines in my other CL, masking whatever the real problem was.
2016-02-01 19:15:37 +00:00
93591e7568 Merge pull request #508 from bradfitz/master
server: break up the Server.Serve method into some reusable parts
2016-01-29 15:51:48 -08:00
9d2ecf553a server: break up the Server.Serve method into some reusable parts
Updates grpc/grpc-go#75
2016-01-29 23:20:54 +00:00
2e0ced7711 Merge pull request #513 from iamqizhao/master
Simplify compression API
2016-01-29 15:17:11 -08:00
af8888dc8d remove Compressor/DecompressorGenerator 2016-01-29 14:38:20 -08:00
3f30c980d6 Merge pull request #509 from iamqizhao/master
Tune the server accepting code
2016-01-29 10:31:52 -08:00
9ec0eadc55 fix a nil map access bug 2016-01-28 18:51:38 -08:00
35db64de36 Tune the server accepting code 2016-01-28 15:59:36 -08:00
23d551898c Merge pull request #505 from iamqizhao/master
Force flush headers frame for bi-di streaming
2016-01-27 19:03:04 -08:00
6d87263bd5 add test 2016-01-27 18:34:24 -08:00
086f6de8a8 force flush headers frame for server streaming and bi-di streaming 2016-01-27 16:39:34 -08:00
1147a9f0e9 Merge pull request #504 from iamqizhao/master
remove some commented code left from previous PRs
2016-01-26 17:49:40 -08:00
48d3f37c1f remove some commented code left from previous PR 2016-01-26 16:21:22 -08:00
e29d659177 Merge pull request #500 from iamqizhao/master
Support connection level compression
2016-01-25 14:39:43 -08:00
8ced3f96cb gofmt 2016-01-25 12:48:13 -08:00
6ad5faf0d7 more comments 2016-01-25 12:46:28 -08:00
a9cd71320c add more comments 2016-01-25 11:52:24 -08:00
4258b32de7 Don't create buffer if compressor is nil 2016-01-25 11:47:04 -08:00
61d7c39d4c comments and gofmt 2016-01-25 11:18:41 -08:00
da3bb0c9f7 Support compression 2016-01-22 18:21:41 -08:00
5da22b92e9 Merge pull request #492 from iamqizhao/master
Add missing trace finish on an uncommon code path
2016-01-14 17:41:25 -08:00
8e76d451dd Add missing trace finish on an uncommon code path 2016-01-14 17:01:22 -08:00
b24c357536 Merge pull request #491 from iamqizhao/master
Finish tracing when failing to create a client stream
2016-01-14 15:03:58 -08:00
7172d5c7a6 Still show trace for the client streams which failed to create 2016-01-14 14:53:07 -08:00
59c74732bb Don't trace when failing to create a cleint stream 2016-01-14 14:38:45 -08:00
9fafaa3e4f Merge pull request #490 from iamqizhao/master
Specialize connection error handling
2016-01-14 12:27:47 -08:00
47fc4a2936 Specialize connection error handling to avoid goroutine leaking in some cases 2016-01-14 12:24:00 -08:00
7ed4629849 Merge pull request #488 from iamqizhao/master
Move callInfo into the right position
2016-01-07 14:58:23 -08:00
ea6e7189de Move callInfo into the right position 2016-01-07 14:44:36 -08:00
0770c49273 Merge pull request #487 from iamqizhao/master
some missing comments
2016-01-07 14:43:47 -08:00
c1330e18aa some missing comments 2016-01-07 14:18:20 -08:00