2852 Commits

Author SHA1 Message Date
0bc7c3280e Revert "Less mem (#1987)" (#2049)
This reverts commit 7a8c9895074e03bc7fcff30bd561eaef4fa76dfa.
2018-05-03 11:37:59 -07:00
ed2472917f client: fix interceptors after recent cleanup (#2046)
This is a partial revert of #2027 which seems to have broken the ability
to inject payload inspecting client interceptors. Specifically it causes
this test to break:
eb0079f598/bigtable/bigtable_test.go (L949-L971)

With:
panic: interface conversion: grpc.ClientStream is *bigtable.requestCountingInterceptor, not *grpc.clientStream [recovered]
	panic: interface conversion: grpc.ClientStream is *bigtable.requestCountingInterceptor, not *grpc.clientStream

Which seems to be caused by invoke() expecting a clientStream from a
ClientConn:

7c204fd174/call.go (L74)
2018-05-03 09:00:38 -07:00
e9443916b5 internal: vet.sh quits when it sees macosx (#2048) 2018-05-02 16:47:25 -07:00
9b03f4f00b channelz: update proto to canonical version and rename directory (#2044)
* rename service_proto dir to match proto package it contains.

* Update channelz proto to add version.

* Update channelz proto file.
2018-05-02 16:41:45 -07:00
3592bccfd9 interop: Fix unimplemented method test (#2040)
* Don't send nil requests.

* Fix import name and get rid of condition.

* Let registered encoder deal with nil requests.

* Break encode into encode and compress.
2018-05-02 16:08:12 -07:00
7c204fd174 health: set health proto canonical path (#2038) 2018-05-02 14:02:14 -07:00
f8dbc38bdc Fix "deprecated" function godoc comments to match standard formatting (#2027) 2018-05-02 08:52:49 -07:00
e538e04cad proto: update generated code (#2039) 2018-05-01 12:53:20 -07:00
1cd00ab9ab Rename proto import. (#2036) 2018-04-30 16:59:54 -07:00
8508314f82 Fix typos. (#2035) 2018-04-30 15:22:55 -07:00
17a5d9ce39 credentials/alts: Refer to ALTS gRPC types by a different package (#2028) 2018-04-30 12:57:04 -07:00
71fe8dfd61 http2Client: send reset stream when closing the stream on protocol error (#2030) 2018-04-30 11:16:00 -07:00
8b85126464 Stage 3: Channelz server implementation (#1919) 2018-04-30 11:14:29 -07:00
7a8c989507 Less mem (#1987)
* Export changes to OSS.

* First commit.

* Cherry-pick.

* Documentation.

* Post review updates.
2018-04-30 09:54:33 -07:00
fc37cf1364 server: export ServerTransportStreamFromContext for unary interceptors to control headers/trailers (#2019) 2018-04-26 17:38:15 -07:00
07709e8a3d dns resolver: create rand seed at init time (#2007) 2018-04-26 15:10:23 -07:00
66090d990b vet: disallow importing "unsafe" (#2024) 2018-04-26 14:24:26 -07:00
7263089022 stickiness: avoid using unsafe (#2023)
App Engine doesn't allow use of unsafe.
2018-04-25 10:01:33 -07:00
247a5d4487 Fix typos (#2020) 2018-04-24 16:09:35 -07:00
9c2d308aed travis: skip vet install for 386 (#2018) 2018-04-24 13:20:09 -07:00
e8a6e2844b stickiness: add stickiness support (#1969) 2018-04-24 10:37:52 -07:00
4166ea7dad Stage 2: Channelz metric collection (#1909) 2018-04-23 11:22:25 -07:00
75d37eff66 credentials/alts: Add ServiceOption for server-side ALTS creation (#2009)
* Move handshaker_service_address flag to binaries
2018-04-23 11:11:20 -07:00
4172bfc25e documentation: add instructions for running tests locally (#2006) 2018-04-19 17:17:21 -07:00
b4a36ce6a6 go vet: fix composite literal uses unkeyed fields (#2005) 2018-04-19 17:16:53 -07:00
d27df52a27 documentation: add OAuth2 doc and example (#2003) 2018-04-18 11:25:19 -07:00
6e5192d28c reflection: regenerate pb.go file after typo fix (#2002)
The typo in proto file was fixed, but not pg.go file. This was causing failures
in travis cron tests.
2018-04-17 09:46:15 -07:00
5d8897144f Remove unnecessary type conversions (unconvert) (#1995)
This fixes:
grpc/interop/test_utils.go:156:17: unnecessary conversion
interop/test_utils.go:201:17: unnecessary conversion
resolver/dns/dns_resolver.go:190:31: unnecessary conversion
transport/flowcontrol.go:36:47: unnecessary conversion
transport/flowcontrol.go:41:47: unnecessary conversion
transport/flowcontrol.go:42:47: unnecessary conversion
transport/flowcontrol.go:43:47: unnecessary conversion
transport/http2_client.go:788:16: unnecessary conversion
transport/http2_client.go:798:36: unnecessary conversion
transport/http2_client.go:809:28: unnecessary conversion
transport/http2_client.go:834:31: unnecessary conversion
transport/http2_client.go:839:30: unnecessary conversion
transport/http2_client.go:864:23: unnecessary conversion
transport/http2_server.go:513:16: unnecessary conversion
transport/http2_server.go:524:36: unnecessary conversion
transport/http2_server.go:534:28: unnecessary conversion
transport/http2_server.go:557:31: unnecessary conversion
transport/http2_server.go:562:30: unnecessary conversion
transport/http_util.go:350:31: unnecessary conversion
2018-04-16 10:18:17 -07:00
7de9139327 Fix typos (#1994) 2018-04-16 10:03:02 -07:00
ef3a1ad826 Merge pull request #1996 from knweiss/gosimple
Simplifications and cleanups (gosimple)
2018-04-16 09:32:20 -07:00
35a2846daa Various simplifications (gosimple)
This fixes:
clientconn.go:948:3: should write m = cc.sc.Methods[method[:i+1]] instead of m, _ = cc.sc.Methods[method[:i+1]] (S1005)
encoding/proto/proto_test.go:43:5: should use !bytes.Equal(p.GetBody(), expectedBody) instead (S1004)
resolver/dns/dns_resolver.go:260:2: should merge variable declaration with assignment on next line (S1021)
resolver/dns/dns_resolver.go:344:2: should use 'return <expr>' instead of 'if <expr> { return <bool> }; return <bool>' (S1008)
2018-04-15 15:32:33 +02:00
4d9544a0fd Simplify make() (gosimple)
This fixes:
benchmark/worker/benchmark_client.go:151:36: should use make([]*grpc.ClientConn, connCount) instead (S1019)
benchmark/worker/benchmark_client.go:231:47: should use make([]lockingHistogram, rpcCountPerConn * len(conns)) instead (S1019)
benchmark/worker/benchmark_client.go:343:39: should use make([]*stats.Histogram, len(bc.lockingHistograms)) instead (S1019)
benchmark/worker/benchmark_client.go:369:22: should use make([]uint32, len(mergedHistogram.Buckets)) instead (S1019)
encoding/encoding.go:85:47: should use make(map[string]Codec) instead (S1019)
proxy_test.go:116:26: should use make([]byte, len(msg)) instead (S1019)
2018-04-15 15:32:33 +02:00
749a0db289 Use time.Since() helper function (gosimple)
(I've dropped similar gosimple cleanups using time.Until() as this API is not
available in go1.6 and go1.7)
2018-04-15 15:32:33 +02:00
95bbf69653 Remove redundant return statements (gosimple)
This fixes:
balancer/base/balancer.go:149:2: redundant return statement (S1023)
balancer_v1_wrapper.go:260:2: redundant return statement (S1023)
balancer_v1_wrapper.go:273:2: redundant return statement (S1023)
balancer_v1_wrapper.go:285:2: redundant return statement (S1023)
benchmark/benchmark.go:68:2: redundant return statement (S1023)
clientconn.go:1461:2: redundant return statement (S1023)
grpclb.go:223:2: redundant return statement (S1023)
grpclb.go:260:2: redundant return statement (S1023)
grpclb_util.go:201:2: redundant return statement (S1023)
rpc_util.go:278:50: redundant return statement (S1023)
rpc_util.go:296:56: redundant return statement (S1023)
rpc_util.go:314:56: redundant return statement (S1023)
rpc_util.go:333:53: redundant return statement (S1023)
rpc_util.go:354:52: redundant return statement (S1023)
rpc_util.go:387:56: redundant return statement (S1023)
rpc_util.go:416:53: redundant return statement (S1023)
stream.go:651:2: redundant return statement (S1023)
2018-04-15 12:43:34 +02:00
35aeaeb587 documentation: mention DialContext is non-blocking by default (#1970) 2018-04-12 15:11:22 -07:00
c4a6e7589b documentation: mention Register functions should be call at init time (#1975) 2018-04-12 15:11:04 -07:00
0c6b34bbc3 cleanup: extend dial context for TestFailFastRPCErrorOnBadCertificates to 10 seconds (#1984) 2018-04-12 15:05:04 -07:00
2783898b89 Fix Test: race between t.Write() and t.closeStream() (#1989) 2018-04-12 14:13:47 -07:00
db0f0713e3 Small test readability fixes (#1985) 2018-04-11 10:12:06 -07:00
858463ac27 documentation: mention peer will only be populated after RPC completes (#1982) 2018-04-10 15:56:38 -07:00
b1807c3189 Channelz: more stable tesing (#1983) 2018-04-10 14:27:42 -07:00
844b2a520b grpclb: fix issues caused by caching SubConns (#1977) 2018-04-10 14:23:07 -07:00
cf3bf7f774 createTransport: check for SHUTDOWN before assigning TransientFailure to ac.state (#1979) 2018-04-10 12:48:04 -07:00
e8d9fec333 resolver/dns: Typo in lookupHost failure warning (#1981) 2018-04-10 10:35:41 -07:00
7f73c863c0 Channelz: Entity Registration and Deletion (#1811) 2018-04-09 11:13:06 -07:00
7316918402 clientconn: add support for unix network in DialContext. (#1883) 2018-04-09 11:12:34 -07:00
30fb59a430 documentation: Mark compresser and decompresser as deprecated (#1971) 2018-04-06 11:05:14 -07:00
85ce056528 grpclb: cache SubConns for 10 seconds after it is removed from the backendlist (#1957) 2018-04-05 14:10:33 -07:00
4b17696981 internal: clean up deprecated Invoke() usage (#1966) 2018-04-05 14:09:56 -07:00
76b07ed73d Mark old balancer and naming APIs as deprecated (#1951) 2018-04-05 13:12:31 -07:00