1271 Commits

Author SHA1 Message Date
7353dc76d0 Update grpc-auth-support.md 2015-03-09 11:41:38 -07:00
fa37faf0f0 Merge pull request #105 from iamqizhao/master
Remove a debug log
2015-03-06 17:38:52 -08:00
e6b45390ca Remove a debug log 2015-03-06 17:35:54 -08:00
02fe8a71d3 gotutorial.md: Remove duplicate sentence. 2015-03-06 10:58:41 -08:00
076e591ca4 Merge pull request #103 from iamqizhao/master
fix double wrapping of rpc status
2015-03-05 19:01:37 -08:00
85034d5828 fix double wrapping of rpc status 2015-03-05 18:52:06 -08:00
106c4cfac5 Merge pull request #93 from iamqizhao/master
Support (re)connect time-out
2015-03-05 15:53:32 -08:00
1182c6e87c minor polish 2015-03-05 14:24:32 -08:00
57c1951dc9 tightened some rpcErr loose ends and revised some tests 2015-03-05 13:56:48 -08:00
5c27dd6a7a fix a bug 2015-03-05 09:45:50 -08:00
aae62e6051 remove unused import 2015-03-05 01:52:17 -08:00
ac2cbeb2e7 Merge branch 'master' of https://github.com/grpc/grpc-go 2015-03-05 01:47:08 -08:00
59cf05b4f5 fix a comment 2015-03-05 01:46:30 -08:00
8dd67cb297 Merge pull request #100 from adg/master
drop usage of obsolete oauth2.Context
2015-03-04 20:04:26 -08:00
fa9ecddd2c drop usage of obsolete oauth2.Context 2015-03-05 14:46:56 +11:00
a131f81526 Merge pull request #97 from iamqizhao/b2
fix a comment
2015-03-04 19:12:39 -08:00
7efb0d7d75 fix a comment 2015-03-04 19:10:21 -08:00
10f29ffc09 fix a function comment 2015-03-04 18:16:53 -08:00
7bd92dc8cb Merge branch 'master' of https://github.com/grpc/grpc-go 2015-03-04 16:03:27 -08:00
ffb2384582 Merge pull request #95 from wonderfly/master
Cosmetic updates to the route guide example
2015-03-04 16:03:10 -08:00
9ff931f934 Small fix to client.go 2015-03-04 15:44:58 -08:00
91a7361187 address some comments 2015-03-04 15:14:52 -08:00
d83ccd2feb Use Fatalf instead 2015-03-04 14:57:51 -08:00
7bf60c1cd4 addressed some comments 2015-03-04 14:37:12 -08:00
c33e9f7fa4 addressed some comments 2015-03-04 14:25:57 -08:00
082bf01a4f addressed some comments 2015-03-04 13:32:58 -08:00
b7ae0a2c89 Merge branch 'master' of https://github.com/grpc/grpc-go 2015-03-04 13:30:25 -08:00
09fbfbf553 addressed some comments 2015-03-04 13:29:15 -08:00
8d7b4ade87 addressed some comments 2015-03-04 13:23:39 -08:00
8304bc408e addressed some comments 2015-03-04 13:20:21 -08:00
28ad38be17 close ready when ClientConn closes 2015-03-04 13:00:47 -08:00
c73e40b804 address some review comments 2015-03-04 11:15:10 -08:00
b052a1255f Merge branch 'master' of https://github.com/grpc/grpc-go 2015-03-04 11:14:39 -08:00
757a7ce4cb remove err checking because bytes.Buffer.Write and bytes.Buffer.WriteByte always return nil 2015-03-04 00:50:30 -08:00
ea8a568350 Merge pull request #87 from matttproud/testing/benchmark/encode
Benchmark encode and cut an encoding inefficiency.
2015-03-04 00:36:29 -08:00
351e2d0297 add more tests for dial timeout and fix some bugs 2015-03-03 19:06:44 -08:00
fa215c2d4b gofmt -w 2015-03-03 17:10:14 -08:00
a5ca6e56d2 Support timeout for grpc.Dial 2015-03-03 17:08:39 -08:00
c91d17acf1 Benchmark encode and cut encoding inefficiency.
This commit introduces the first microbenchmark for grpc, wherein
`encode` is benchmarked according to message size.  A conclusion of
the benchmark is that the removal of type switching found in
`binary.Write`, which is used in `encode` produces the following
encoding time and memory allocation footprint:

```
$ # Return to previous commit but benchmark.
$ go test ./... -test.bench="Benchmark*" > /tmp/before
$ # Return to working copy.
$ go test ./... -test.bench="Benchmark*" > /tmp/after
$ benchcmp /tmp/before /tmp/after
benchmark                 old ns/op     new ns/op     delta
BenchmarkEncode1B         1282          936           -26.99%
BenchmarkEncode1KiB       4865          4184          -14.00%
BenchmarkEncode8KiB       22686         21560         -4.96%
BenchmarkEncode64KiB      134451        116762        -13.16%
BenchmarkEncode512KiB     514044        361224        -29.73%
BenchmarkEncode1MiB       767096        636725        -17.00%

benchmark                 old MB/s     new MB/s     speedup
BenchmarkEncode1B         6.24         8.55         1.37x
BenchmarkEncode1KiB       212.11       246.63       1.16x
BenchmarkEncode8KiB       361.46       380.33       1.05x
BenchmarkEncode64KiB      487.50       561.35       1.15x
BenchmarkEncode512KiB     1019.94      1451.45      1.42x
BenchmarkEncode1MiB       1366.95      1646.84      1.20x

benchmark                 old allocs     new allocs     delta
BenchmarkEncode1B         6              3              -50.00%
BenchmarkEncode1KiB       8              5              -37.50%
BenchmarkEncode8KiB       8              5              -37.50%
BenchmarkEncode64KiB      8              5              -37.50%
BenchmarkEncode512KiB     8              5              -37.50%
BenchmarkEncode1MiB       8              5              -37.50%

benchmark                 old bytes     new bytes     delta
BenchmarkEncode1B         384           328           -14.58%
BenchmarkEncode1KiB       2816          2760          -1.99%
BenchmarkEncode8KiB       17283         17227         -0.32%
BenchmarkEncode64KiB      147856        147802        -0.04%
BenchmarkEncode512KiB     1065344       1065288       -0.01%
BenchmarkEncode1MiB       2113920       2113864       -0.00%
```

..., which is apropos of the comment in [encoding/binary]
(http://golang.org/pkg/encoding/binary), wherein ...

> This package favors simplicity over efficiency.

... is stated.

If `encode` is deemed to need further memory efficiencies, a mechanism
whereby a `proto.Buffer` is retained may be warranted, which is why the
original TODO remains.  The proposed improvement in this change is
simple and low-hanging.

I did not want to introduce yet-another protocol buffer message for
tests, but the ones under ...

> interop/grpc_testing/test.proto
> test/grpc_testing/test.proto

... have a fundamental dependency on `grpc` package due to their
generated stubs, which produces a cycle in the imports if the benchmark
were to attempt to import them for profiling.  The newly created ...

> test/grpc_message/test.proto

... protocol buffer package has no generated RPC service stubs, which
means it can be imported into the `grpc` package root without cycle.
2015-03-03 09:42:00 +01:00
84451c554b Sync with upstream 2015-03-01 17:12:39 -08:00
46f39d3ebd Cosmetic updates to the route guide example 2015-03-01 17:05:46 -08:00
575a9b2af8 Merge pull request #86 from domesticmouse/patch-1
Minor typo
2015-03-01 12:36:16 -08:00
786d10d0a3 Minor typo 2015-02-28 14:29:36 +11:00
3606a18f7b fix server-side -> client-side cut-and-paste-o 2015-02-27 16:30:00 -05:00
62921e6780 fix typo 2015-02-27 13:12:27 -08:00
63953dd7e5 Merge pull request #83 from SebastianM/godoc
add godoc.org badge
2015-02-27 11:11:54 -08:00
17988fc724 Some edits/rewriting of Go tutorial 2015-02-27 16:47:51 +00:00
2b228c8c27 add godoc.org badge 2015-02-27 10:55:34 +01:00
333f8f218a Merge pull request #81 from mattn/fix-fatal
Use Fatalf instead
2015-02-26 19:02:38 -08:00
5c34a9df1a Merge pull request #82 from dsymonds/patch-1
Remove manual GOPATH manipulation.
2015-02-26 19:02:08 -08:00