193 Commits

Author SHA1 Message Date
b681a11d08 A few more improvements to the benchmark code. (#2840)
* A few more improvements to the benchmark code.

* In benchmain/main.go:
  * Define types for function arguments to make code more readable
  * Significantly simplify the code as a result of stats package refactor.
* In benchresult/main.go
  * Simplify code as a result of stats package refactor.
* In stats/stats.go
  * Define and expose featureIndex enum.
  * Refactor the types used to store features, results, stats etc.
  * Provide easy to use methods to add/modify/read/dump stats info.
* Delete stats/util.go - dead code.
2019-06-10 09:53:35 -07:00
c2e0a6d772 Fix a typo. (#2826) 2019-05-21 11:09:30 -07:00
7c03793042 benchmark: refactor the benchmark code. (#2820)
benchmark: refactor the benchmark code.
2019-05-20 16:01:37 -07:00
4a199db194 xds: split proto imports for message and service (#2812) 2019-05-14 15:15:08 -07:00
9949ee0c45 xds: lrs load store (#2779) 2019-05-07 10:06:40 -07:00
8260df7a61 grpc: implementation of PreparedMsg API
grpc: implementation of PreparedMsg API
2019-04-19 14:08:08 -07:00
22c2121b7d benchmark: exit after printing help when using -h (#2701) 2019-03-21 12:04:35 -07:00
40cb5618f4 dialOption: export WithContextDialer() (#2629)
fixes #2627
2019-02-25 15:22:10 -08:00
b86a9dbd22 documentation: Adds package level comments (#2612)
* ADDED package level comments for: benchmark/, examples/helloworld/

* UPDATED code to run gofmt

* FIXED linter errors

* FIXED spelling error

* FIXED documentation based on feedback

* FIXED comment to add pointer to another file

* ADDED reference to start server

* ADDED fix to include command to start server
2019-02-21 13:05:00 -08:00
954fe27324 benchmark: Unconstrained streaming benchmark (#2512)
* Adds unconstrained streaming benchmarks.
* Adds throughput to all scenarios.
* Adds comment to exported function.
* Adds comment to the new rpc.
* Adds a new run mode for unconstrained benchmarks.
* Converts counters to uint64s.
* Decreases default warm up time.
* Addresses PR comments.
* Deletes an unnecessary select/case
* Explains the use of RecvMsg rather than Recv.
2019-01-11 17:37:31 -08:00
04ea82009c cleanup: replace "x/net/context" import with "context" (#2439) 2018-11-12 13:30:41 -08:00
59a2cfbdf9 Remove support for Go1.6-1.8 (#2428) 2018-11-01 15:43:42 -07:00
90f728eaf7 Remove shadowing of built-ins (#2290) 2018-09-05 09:05:40 -07:00
da7e20b83e channelz: turn on channelz when importing service package, delete RegisterChannelz from grpc package (#2277) 2018-08-29 11:01:36 -07:00
8e36593ad9 go generate: update proto files (#2236) 2018-07-25 11:40:12 -07:00
8c15646409 Benchmark: fix build tags (#2099) 2018-07-12 13:06:42 -07:00
39a411827d internal: Update proto generated code (#2133) 2018-06-08 17:54:26 -07:00
dea4e57312 Benchmarks that runs server and client and separate processes. (#1952) 2018-05-21 16:00:01 -07:00
f669235193 internal: update proto generated code (#2093) 2018-05-21 09:59:26 -07:00
161c19534c benchmark: listen on all addresses in benchmark servers (#2073) 2018-05-14 17:26:00 -07:00
a36eb4675a regenerate *.pb.go files due to proto-gen-go update (#2070) 2018-05-11 18:57:54 -07:00
f8dbc38bdc Fix "deprecated" function godoc comments to match standard formatting (#2027) 2018-05-02 08:52:49 -07:00
e538e04cad proto: update generated code (#2039) 2018-05-01 12:53:20 -07:00
4166ea7dad Stage 2: Channelz metric collection (#1909) 2018-04-23 11:22:25 -07:00
7de9139327 Fix typos (#1994) 2018-04-16 10:03:02 -07:00
4d9544a0fd Simplify make() (gosimple)
This fixes:
benchmark/worker/benchmark_client.go:151:36: should use make([]*grpc.ClientConn, connCount) instead (S1019)
benchmark/worker/benchmark_client.go:231:47: should use make([]lockingHistogram, rpcCountPerConn * len(conns)) instead (S1019)
benchmark/worker/benchmark_client.go:343:39: should use make([]*stats.Histogram, len(bc.lockingHistograms)) instead (S1019)
benchmark/worker/benchmark_client.go:369:22: should use make([]uint32, len(mergedHistogram.Buckets)) instead (S1019)
encoding/encoding.go:85:47: should use make(map[string]Codec) instead (S1019)
proxy_test.go:116:26: should use make([]byte, len(msg)) instead (S1019)
2018-04-15 15:32:33 +02:00
749a0db289 Use time.Since() helper function (gosimple)
(I've dropped similar gosimple cleanups using time.Until() as this API is not
available in go1.6 and go1.7)
2018-04-15 15:32:33 +02:00
95bbf69653 Remove redundant return statements (gosimple)
This fixes:
balancer/base/balancer.go:149:2: redundant return statement (S1023)
balancer_v1_wrapper.go:260:2: redundant return statement (S1023)
balancer_v1_wrapper.go:273:2: redundant return statement (S1023)
balancer_v1_wrapper.go:285:2: redundant return statement (S1023)
benchmark/benchmark.go:68:2: redundant return statement (S1023)
clientconn.go:1461:2: redundant return statement (S1023)
grpclb.go:223:2: redundant return statement (S1023)
grpclb.go:260:2: redundant return statement (S1023)
grpclb_util.go:201:2: redundant return statement (S1023)
rpc_util.go:278:50: redundant return statement (S1023)
rpc_util.go:296:56: redundant return statement (S1023)
rpc_util.go:314:56: redundant return statement (S1023)
rpc_util.go:333:53: redundant return statement (S1023)
rpc_util.go:354:52: redundant return statement (S1023)
rpc_util.go:387:56: redundant return statement (S1023)
rpc_util.go:416:53: redundant return statement (S1023)
stream.go:651:2: redundant return statement (S1023)
2018-04-15 12:43:34 +02:00
2759199bf7 Small spelling fixes (unknow -> unknown) (#1868) 2018-02-22 13:10:19 -08:00
46fd263cc8 benchmarks: add flag to benchmain to use bufconn instead of network (#1837)
This will allow us to focus on grpc internals in profiling by excluding the cost of syscalls, which is a significant part of our time spent.
2018-02-15 14:52:38 -08:00
5ba054bf37 encoding: Introduce new method for registering and choosing codecs (#1813) 2018-01-23 11:39:40 -08:00
4f7a2c71d3 compare atomic and mutex performance in case of contention. (#1788) 2018-01-22 18:48:20 -08:00
17c6e90cd5 compare atomic and mutex performance for incrementing/storing one variable (#1757) 2018-01-02 10:46:13 -08:00
b7dc71e7ea Optimize codes.String() method using a switch instead of a slice of indexes (#1712) 2017-12-06 10:50:43 -08:00
abd3e10d78 Add context benchmarks (#1610) 2017-11-07 10:20:24 -08:00
865013bc17 *: replace deprecated grpc.Errorf calls with status.Errorf (#1651) 2017-11-06 10:24:20 -08:00
ac0ac2b80e Speed-up quota pools. (#1636)
* First commit.

* First commit.

* Second commit.

* Post-review update.
2017-11-02 13:39:27 -07:00
fc6acc5e5e latency: Listen on localhost:0 instead of :0 in test (#1640) 2017-11-01 10:52:07 -07:00
5c3d956e18 Re-add support for Go1.6 (#1603) 2017-10-20 12:05:20 -07:00
faebfcb7bf Remove single-entry var blocks (#1589) 2017-10-18 09:59:23 -07:00
c8405557a4 Remove Go1.6 support (#1492) 2017-10-04 13:57:10 -07:00
8230f98ef7 benchmark: add type assertion benchmarks (#1556) 2017-10-03 13:03:49 -07:00
8214c28a62 Make IO Buffer size configurable. (#1544)
* Make IO Buffer size configurable.

* Fixing typo
2017-09-28 14:11:14 -07:00
a68137c927 Revert "Added localhost to net.Listen() calls to avoid macOS firewall dialog." (#1541)
This reverts commit c67cd636f91e849f8677733bcdd60ea8c15d4aa6.
2017-09-27 00:01:17 -07:00
c67cd636f9 Added localhost to net.Listen() calls to avoid macOS firewall dialog. (#1539) 2017-09-26 10:19:45 -07:00
d4b75ebd4f benchmark: add primivites benchmark for Unlocking via defer vs. inline (#1534) 2017-09-21 12:46:03 -07:00
1253dac14b benchmain: format output of benchmark to a table (#1493) 2017-09-20 15:06:19 -07:00
dce316936b Move primitives benchmarks to package primitives_test (#1522) 2017-09-19 16:43:00 -07:00
c443156028 benchmark: add primitives benchmarks for informational purposes (#1501) 2017-09-11 10:49:50 -07:00
d6870035ab Check "x/net/context" with go vet like "context" (#1490)
* Check "x/net/context" with `go vet` like "context"

Includes a signficant revamp of .travis.yml to execute a separate script for
all of the things we check before allowing a merge.

* fix bug in benchmain
2017-08-29 15:40:57 -07:00