1079 Commits

Author SHA1 Message Date
0142d18c83 Merge pull request #406 from iamqizhao/master
rename some interop client flags
2015-10-20 19:12:33 -07:00
7afe4e5cec rename some interop client flags 2015-10-20 16:49:37 -07:00
8309464e39 Merge pull request #405 from iamqizhao/master
recover the content-type check
2015-10-20 16:27:30 -07:00
6a026b9f10 recover the content-type check 2015-10-20 16:20:52 -07:00
fe63ec9c80 Merge pull request #404 from iamqizhao/master
attach content-type to trailer if the trailer is the only response.
2015-10-20 16:13:42 -07:00
9439d59e26 attach content-type to trailer if the trailer is the only response. 2015-10-20 16:05:38 -07:00
9210c87f85 Merge pull request #402 from iamqizhao/master
change the type of length from uint32 to uint
2015-10-15 13:29:51 -07:00
984280ba37 change the type of length 2015-10-15 13:22:54 -07:00
a90aeac84e Merge pull request #401 from iamqizhao/master
some cleanup
2015-10-15 11:07:02 -07:00
61c1259226 some cleanup 2015-10-15 10:59:39 -07:00
ebeb34ad2f Merge pull request #400 from dsymonds/master
Fix decoding of message headers for messages with lengths >= 2^24.
2015-10-15 01:16:43 -07:00
d3cb35a50a Fix decoding of message headers for messages with lengths >= 2^24.
recvMsg was interpreting buf[1] as the payload format instead of buf[0];
since compressionNone (the only thing supported) == 0, recvMsg got lucky
for message lengths under 2^24, which has buf[1] == 0.

Fix the error, and ditch the constants in recvMsg. I think they were the
cause of the bug.

Also make encode fail more clearly if someone tries to transmit a
message that exceeds 2^32 bytes.

Fixes #399.
2015-10-15 18:56:48 +11:00
f7d1653e30 Merge pull request #394 from iamqizhao/master
fix a comment
2015-10-08 14:29:52 -07:00
c0d1abc00e fix a comment 2015-10-08 14:22:00 -07:00
471376a2ac Merge pull request #393 from iamqizhao/master
Part1: revise Picker API
2015-10-08 11:18:22 -07:00
2097711be8 add picker.go 2015-10-08 11:12:04 -07:00
390cd42894 revise Picker API 2015-10-08 11:05:59 -07:00
1e4205e370 Merge pull request #392 from iamqizhao/master
bug fix: stop busy wait on new transport
2015-10-08 09:14:54 -07:00
ec8414396c bug fix: stop busy wait on new transport 2015-10-08 09:09:06 -07:00
86d9dff62d Merge pull request #390 from iamqizhao/master
refactor naming package
2015-10-07 17:37:29 -07:00
a80cf8dfe9 add a mutex to guard w.kv 2015-10-07 16:56:15 -07:00
8d7cb9253d refactor naming package 2015-10-07 16:40:10 -07:00
6c8d213d08 Merge pull request #385 from nuss-justin/master
Avoid some allocations in recvMsg
2015-10-06 22:39:18 -07:00
e2cb78fabb Combine const declarations into one block 2015-10-07 06:37:58 +02:00
02fd7b3ab4 Merge pull request #389 from iamqizhao/master
remove sync.WaitGroup param from ServerTransport.HandleStream
2015-10-06 16:58:19 -07:00
63a6c4155a remove sync.WaitGroup param from ServerTransport.HandleStream 2015-10-06 16:44:30 -07:00
b36fcbe215 Merge pull request #388 from iamqizhao/master
fix the wrong reference link
2015-10-06 16:10:44 -07:00
e63d714a45 fix the wrong reference link 2015-10-06 16:05:45 -07:00
4673c7de99 Merge pull request #384 from mwitkow-io/bugfix/fix_stream_codec_errors_take2
fix difference between unitary and stream codec error handling
2015-10-06 15:58:37 -07:00
5165699f37 Define constants for header size and format index 2015-10-06 20:53:17 +02:00
c2ad501830 Merge pull request #387 from iamqizhao/master
Refactor server side tracing
2015-10-06 11:38:03 -07:00
95d129f7d8 Remove unnecessary uint8 conversion 2015-10-06 06:32:01 +02:00
492a718373 fix comments 2015-10-05 18:02:06 -07:00
6d4c5aef64 remove dead comments 2015-10-05 17:59:10 -07:00
9db3ca85c7 gofmt -w 2015-10-05 17:52:00 -07:00
bc49d12737 refactor servier side trace again 2015-10-05 17:49:53 -07:00
c9fdfdd500 Avoid some allocations in recvMsg
Reading the header by hand avoids some allocations and improves the
performance of recvMsg.

benchmark                              old ns/op     new ns/op     delta
BenchmarkClientStreamc1-8              125267        110733        -11.60%
BenchmarkClientStreamc8-8              21561         20971         -2.74%
BenchmarkClientStreamc64-8             13573         12825         -5.51%
BenchmarkClientStreamc512-8            13937         13300         -4.57%
BenchmarkClientUnaryc1-8               223208        257968        +15.57%
BenchmarkClientUnaryc8-8               46168         45618         -1.19%
BenchmarkClientUnaryc64-8              33740         33038         -2.08%
BenchmarkClientUnaryc512-8             33137         32663         -1.43%
BenchmarkClientStreamNoTracec1-8       115559        107506        -6.97%
BenchmarkClientStreamNoTracec8-8       20853         20376         -2.29%
BenchmarkClientStreamNoTracec64-8      12119         11935         -1.52%
BenchmarkClientStreamNoTracec512-8     13087         12479         -4.65%
BenchmarkClientUnaryNoTracec1-8        225577        244701        +8.48%
BenchmarkClientUnaryNoTracec8-8        42211         41884         -0.77%
BenchmarkClientUnaryNoTracec64-8       30313         29655         -2.17%
BenchmarkClientUnaryNoTracec512-8      29914         29637         -0.93%

benchmark                              old allocs     new allocs     delta
BenchmarkClientStreamc1-8              46             40             -13.04%
BenchmarkClientStreamc8-8              47             41             -12.77%
BenchmarkClientStreamc64-8             46             40             -13.04%
BenchmarkClientStreamc512-8            46             40             -13.04%
BenchmarkClientUnaryc1-8               100            91             -9.00%
BenchmarkClientUnaryc8-8               100            91             -9.00%
BenchmarkClientUnaryc64-8              100            91             -9.00%
BenchmarkClientUnaryc512-8             96             88             -8.33%
BenchmarkClientStreamNoTracec1-8       42             36             -14.29%
BenchmarkClientStreamNoTracec8-8       43             37             -13.95%
BenchmarkClientStreamNoTracec64-8      42             36             -14.29%
BenchmarkClientStreamNoTracec512-8     42             36             -14.29%
BenchmarkClientUnaryNoTracec1-8        87             78             -10.34%
BenchmarkClientUnaryNoTracec8-8        87             78             -10.34%
BenchmarkClientUnaryNoTracec64-8       87             78             -10.34%
BenchmarkClientUnaryNoTracec512-8      84             77             -8.33%

benchmark                              old bytes     new bytes     delta
BenchmarkClientStreamc1-8              2015          1919          -4.76%
BenchmarkClientStreamc8-8              2016          1920          -4.76%
BenchmarkClientStreamc64-8             2015          1919          -4.76%
BenchmarkClientStreamc512-8            2007          1901          -5.28%
BenchmarkClientUnaryc1-8               5981          5837          -2.41%
BenchmarkClientUnaryc8-8               5980          5837          -2.39%
BenchmarkClientUnaryc64-8              5956          5813          -2.40%
BenchmarkClientUnaryc512-8             5743          5611          -2.30%
BenchmarkClientStreamNoTracec1-8       1887          1791          -5.09%
BenchmarkClientStreamNoTracec8-8       1888          1792          -5.08%
BenchmarkClientStreamNoTracec64-8      1916          1789          -6.63%
BenchmarkClientStreamNoTracec512-8     1894          1811          -4.38%
BenchmarkClientUnaryNoTracec1-8        4301          4158          -3.32%
BenchmarkClientUnaryNoTracec8-8        4301          4157          -3.35%
BenchmarkClientUnaryNoTracec64-8       4282          4140          -3.32%
BenchmarkClientUnaryNoTracec512-8      4131          4077          -1.31%
2015-10-05 19:52:11 +02:00
1a7cf7f696 fix difference between unitary and stream codec error handling 2015-10-03 18:43:53 +01:00
3e7b7e58f4 Merge pull request #383 from iamqizhao/master
remove unnecessary go statement
2015-10-02 16:12:33 -07:00
9a7e50e3d9 remove unnecessary go statement 2015-10-02 16:04:55 -07:00
953872274c Merge pull request #382 from iamqizhao/master
Refactor server side tracing
2015-10-02 15:52:24 -07:00
4648452efa fix another methodFamily 2015-10-02 15:40:06 -07:00
b4aa9eae10 fix methodFamily breakage 2015-10-02 15:38:37 -07:00
59258581ef remove temp changes 2015-10-02 15:14:27 -07:00
2e43c33e71 revert trace.go change 2015-10-02 15:12:44 -07:00
2aad9ba05f server side tracing refactoring 2015-10-02 15:06:41 -07:00
bd2da124cc Merge branch 'master' of https://github.com/grpc/grpc-go 2015-10-02 14:26:13 -07:00
89b3f25e99 Merge pull request #380 from grpc/revert-372-bugfix/fix_stream_codec_errors
Revert "fix difference between unitary and stream codec error handling"
2015-10-02 14:10:41 -07:00
04b80892a6 Revert "fix difference between unitary and stream codec error handling" 2015-10-02 14:07:05 -07:00
9985d70a6d Merge branch 'master' of https://github.com/grpc/grpc-go 2015-10-02 13:30:47 -07:00