From f8063d3b62072e0eb03814d1db7219efef65c3a9 Mon Sep 17 00:00:00 2001 From: Menghan Li Date: Thu, 27 Sep 2018 13:50:06 -0700 Subject: [PATCH] tests: fix leak in TestDialParseTargetUnknownScheme (#2320) Do a non-blocking send so if dial is called again in a retry, it won't block forever. --- resolver_conn_wrapper_test.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/resolver_conn_wrapper_test.go b/resolver_conn_wrapper_test.go index 6f1367a2..e87b9420 100644 --- a/resolver_conn_wrapper_test.go +++ b/resolver_conn_wrapper_test.go @@ -97,8 +97,11 @@ func TestDialParseTargetUnknownScheme(t *testing.T) { {"passthrough://a.server.com/google.com", "google.com"}, } { dialStrCh := make(chan string, 1) - cc, err := Dial(test.targetStr, WithInsecure(), WithDialer(func(t string, _ time.Duration) (net.Conn, error) { - dialStrCh <- t + cc, err := Dial(test.targetStr, WithInsecure(), WithDialer(func(addr string, _ time.Duration) (net.Conn, error) { + select { + case dialStrCh <- addr: + default: + } return nil, fmt.Errorf("test dialer, always error") })) if err != nil {