From c7831546a101d7ec5d66da56b3362af28fee1b3e Mon Sep 17 00:00:00 2001 From: Menghan Li Date: Thu, 13 Jun 2019 15:29:28 -0700 Subject: [PATCH] test: extend RPC timeout for TestHTTPHeaderFrameErrorHandlingHTTPMode (#2861) This test sometimes fails with error creating stream due to DeadlineExceeded. It's very hard to reproduce (failed twice in 100000 runs). Extend the RPC timeout in case it's too short. --- test/end2end_test.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/test/end2end_test.go b/test/end2end_test.go index f6549e79..1643870b 100644 --- a/test/end2end_test.go +++ b/test/end2end_test.go @@ -7436,6 +7436,7 @@ func (s *httpServer) start(t *testing.T, lis net.Listener) { } func doHTTPHeaderTest(t *testing.T, errCode codes.Code, headerFields ...[]string) { + t.Helper() lis, err := net.Listen("tcp", "localhost:0") if err != nil { t.Fatalf("Failed to listen. Err: %v", err) @@ -7445,13 +7446,13 @@ func doHTTPHeaderTest(t *testing.T, errCode codes.Code, headerFields ...[]string headerFields: headerFields, } server.start(t, lis) - ctx, cancel := context.WithTimeout(context.Background(), 2*time.Second) - defer cancel() - cc, err := grpc.DialContext(ctx, lis.Addr().String(), grpc.WithInsecure()) + cc, err := grpc.Dial(lis.Addr().String(), grpc.WithInsecure()) if err != nil { t.Fatalf("failed to dial due to err: %v", err) } defer cc.Close() + ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second) + defer cancel() client := testpb.NewTestServiceClient(cc) stream, err := client.FullDuplexCall(ctx) if err != nil {