From c05280cc73cd37f926f1900b56822fe448e52da4 Mon Sep 17 00:00:00 2001 From: Menghan Li Date: Thu, 11 Oct 2018 13:10:45 -0700 Subject: [PATCH] cleanup: remove unused channel ready (#2353) --- clientconn.go | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/clientconn.go b/clientconn.go index b3b22a15..d7ee1062 100644 --- a/clientconn.go +++ b/clientconn.go @@ -885,9 +885,6 @@ type addrConn struct { // Use updateConnectivityState for updating addrConn's connectivity state. state connectivity.State - // ready is closed and becomes nil when a new transport is up or failed - // due to timeout. - ready chan struct{} tearDownErr error // The reason this addrConn is torn down. @@ -994,10 +991,6 @@ func (ac *addrConn) resetTransport(resolveNow bool) { ac.mu.Unlock() return } - if ac.ready != nil { - close(ac.ready) - ac.ready = nil - } ac.transport = nil backoffIdx := ac.backoffIdx @@ -1194,10 +1187,6 @@ func (ac *addrConn) createTransport(backoffNum int, addr resolver.Address, copts ac.cc.handleSubConnStateChange(ac.acbw, ac.state) ac.transport = newTr ac.curAddr = addr - if ac.ready != nil { - close(ac.ready) - ac.ready = nil - } ac.mu.Unlock() @@ -1238,10 +1227,6 @@ func (ac *addrConn) nextAddr() error { return errConnClosing } ac.cc.resolveNow(resolver.ResolveNowOption{}) - if ac.ready != nil { - close(ac.ready) - ac.ready = nil - } backoffDeadline := ac.backoffDeadline b := ac.resetBackoff ac.mu.Unlock() @@ -1319,10 +1304,6 @@ func (ac *addrConn) tearDown(err error) { ac.events.Finish() ac.events = nil } - if ac.ready != nil { - close(ac.ready) - ac.ready = nil - } if channelz.IsOn() { channelz.AddTraceEvent(ac.channelzID, &channelz.TraceEventDesc{ Desc: "Subchannel Deleted",