opensource/grpc-go
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

all: preallocate slices where possible (#4609)

Browse Source
This commit is contained in:
Aliaksandr Mianzhynski
2021-08-11 19:17:59 +03:00
committed by GitHub
parent c7c1e9e0ec
commit 9c668aeab8
19 changed files with 49 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
internal/resolver/dns/dns_resolver.go
View File

@ -323,12 +323,12 @@ func (d *dnsResolver) lookupTXT() *serviceconfig.ParseResult {
}
func (d *dnsResolver) lookupHost() ([]resolver.Address, error) {
var newAddrs []resolver.Address
addrs, err := d.resolver.LookupHost(d.ctx, d.host)
if err != nil {
err = handleDNSError(err, "A")
return nil, err
}
newAddrs := make([]resolver.Address, 0, len(addrs))
for _, a := range addrs {
ip, ok := formatIP(a)
if !ok {

6
internal/resolver/dns/dns_resolver_test.go
View File

@ -30,6 +30,8 @@ import (
"testing"
"time"
"github.com/google/go-cmp/cmp"
"github.com/google/go-cmp/cmp/cmpopts"
"google.golang.org/grpc/balancer"
grpclbstate "google.golang.org/grpc/balancer/grpclb/state"
"google.golang.org/grpc/internal/envconfig"
@ -748,7 +750,7 @@ func testDNSResolver(t *testing.T) {
if cnt == 0 {
t.Fatalf("UpdateState not called after 2s; aborting")
}
if !reflect.DeepEqual(a.addrWant, state.Addresses) {
if !cmp.Equal(a.addrWant, state.Addresses, cmpopts.EquateEmpty()) {
t.Errorf("Resolved addresses of target: %q = %+v, want %+v", a.target, state.Addresses, a.addrWant)
}
sc := scFromState(state)
@ -976,7 +978,7 @@ func testDNSResolverWithSRV(t *testing.T) {
if cnt == 0 {
t.Fatalf("UpdateState not called after 2s; aborting")
}
if !reflect.DeepEqual(a.addrWant, state.Addresses) {
if !cmp.Equal(a.addrWant, state.Addresses, cmpopts.EquateEmpty()) {
t.Errorf("Resolved addresses of target: %q = %+v, want %+v", a.target, state.Addresses, a.addrWant)
}
gs := grpclbstate.Get(state)