opensource/grpc-go
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

grpc: remove mentions of WithBalancerName from comments (#5555)

Browse Source
This commit is contained in:
Easwar Swaminathan
2022-08-02 15:56:37 -07:00
committed by GitHub
parent a077b94683
commit 9bc72deba4
3 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
service_config.go
View File

@ -57,10 +57,9 @@ type lbConfig struct {
type ServiceConfig struct { type ServiceConfig struct {
serviceconfig.Config serviceconfig.Config
// LB is the load balancer the service providers recommends. The balancer // LB is the load balancer the service providers recommends. This is
// specified via grpc.WithBalancerName will override this. This is deprecated; // deprecated; lbConfigs is preferred. If lbConfig and LB are both present,
// lbConfigs is preferred. If lbConfig and LB are both present, lbConfig // lbConfig will be used.
// will be used.
LB *string LB *string
// lbConfig is the service config's load balancing configuration. If // lbConfig is the service config's load balancing configuration. If

2
test/channelz_test.go
View File

@ -1917,8 +1917,6 @@ func (s) TestCZTraceOverwriteChannelDeletion(t *testing.T) {
czCleanup := channelz.NewChannelzStorageForTesting() czCleanup := channelz.NewChannelzStorageForTesting()
defer czCleanupWrapper(czCleanup, t) defer czCleanupWrapper(czCleanup, t)
e := tcpClearRREnv e := tcpClearRREnv
// avoid newTest using WithBalancerName, which would override service
// config's change of balancer below.
e.balancer = "" e.balancer = ""
te := newTest(t, e) te := newTest(t, e)
channelz.SetMaxTraceEntry(1) channelz.SetMaxTraceEntry(1)

1
vet.sh
View File

@ -147,7 +147,6 @@ grpc.NewGZIPDecompressor
grpc.RPCCompressor grpc.RPCCompressor
grpc.RPCDecompressor grpc.RPCDecompressor
grpc.ServiceConfig grpc.ServiceConfig
grpc.WithBalancerName
grpc.WithCompressor grpc.WithCompressor
grpc.WithDecompressor grpc.WithDecompressor
grpc.WithDialer grpc.WithDialer