opensource/grpc-go
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

add the sanity check back and refactor

Browse Source
This commit is contained in:
iamqizhao
2015-06-12 17:31:53 -07:00
parent 7b318285c9
commit 9738b8b68c
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
server.go
View File

@ -38,6 +38,7 @@ import (
"fmt" "fmt"
"io" "io"
"net" "net"
"reflect"
"strings" "strings"
"sync" "sync"
@ -138,9 +139,17 @@ func NewServer(opt ...ServerOption) *Server {
// server. Called from the IDL generated code. This must be called before // server. Called from the IDL generated code. This must be called before
// invoking Serve. // invoking Serve.
func (s *Server) RegisterService(sd *ServiceDesc, ss interface{}) { func (s *Server) RegisterService(sd *ServiceDesc, ss interface{}) {
ht := reflect.TypeOf(sd.HandlerType).Elem()
st := reflect.TypeOf(ss)
if !st.Implements(ht) {
grpclog.Fatalf("grpc: Server.RegisterService found the handler of type %v that does not satisfy %v", st, ht)
}
s.register(sd, ss)
}
func (s *Server) register(sd *ServiceDesc, ss interface{}) {
s.mu.Lock() s.mu.Lock()
defer s.mu.Unlock() defer s.mu.Unlock()
// Does some sanity checks.
if _, ok := s.m[sd.ServiceName]; ok { if _, ok := s.m[sd.ServiceName]; ok {
grpclog.Fatalf("grpc: Server.RegisterService found duplicate service registration for %q", sd.ServiceName) grpclog.Fatalf("grpc: Server.RegisterService found duplicate service registration for %q", sd.ServiceName)
} }