opensource/grpc-go
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Address review comments

Browse Source
This commit is contained in:
Menghan Li
2016-05-16 18:28:16 -07:00
parent 577b4b0d4c
commit 8ca2706d37
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
benchmark/stats/histogram.go
View File

@ -85,7 +85,7 @@ func NewHistogram(opts HistogramOptions) *Histogram {
}
// Print writes textual output of the histogram values.
func (h Histogram) Print(w io.Writer) {
func (h *Histogram) Print(w io.Writer) {
avg := float64(h.Sum) / float64(h.Count)
fmt.Fprintf(w, "Count: %d Min: %d Max: %d Avg: %.2f\n", h.Count, h.Min, h.Max, avg)
fmt.Fprintf(w, "%s\n", strings.Repeat("-", 60))
@ -120,7 +120,7 @@ func (h Histogram) Print(w io.Writer) {
}
// String returns the textual output of the histogram values as string.
func (h Histogram) String() string {
func (h *Histogram) String() string {
var b bytes.Buffer
h.Print(&b)
return b.String()
@ -177,7 +177,7 @@ func (h *Histogram) findBucket(value int64) (int, error) {
return b, nil
}
// Merge takes another histogram, and merges its content into the receiver.
// Merge takes another histogram h2, and merges its content into h.
// The two histograms must be created by equivalent HistogramOptions.
func (h *Histogram) Merge(h2 *Histogram) {
if h.opts != h2.opts {