opensource/grpc-go
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Set number of cores explicitly if it is not specified and add TODO for core list

Browse Source
This commit is contained in:
Menghan Li
2016-05-12 11:34:36 -07:00
parent 31cbd9ae6f
commit 8bdfd5961d
2 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
benchmark/worker/benchmark_client.go
View File

@ -69,6 +69,7 @@ func printClientConfig(config *testpb.ClientConfig) {
// - core list // - core list
grpclog.Printf(" * client type: %v (ignored, always creates sync client)", config.ClientType) grpclog.Printf(" * client type: %v (ignored, always creates sync client)", config.ClientType)
grpclog.Printf(" * async client threads: %v (ignored)", config.AsyncClientThreads) grpclog.Printf(" * async client threads: %v (ignored)", config.AsyncClientThreads)
// TODO: use cores specified by CoreList when setting list of cores is supported in go.
grpclog.Printf(" * core list: %v (ignored)", config.CoreList) grpclog.Printf(" * core list: %v (ignored)", config.CoreList)
grpclog.Printf(" - security params: %v", config.SecurityParams) grpclog.Printf(" - security params: %v", config.SecurityParams)
@ -87,6 +88,8 @@ func setupClientEnv(config *testpb.ClientConfig) {
// TODO: Revisit this for the optimal default setup. // TODO: Revisit this for the optimal default setup.
if config.CoreLimit > 0 { if config.CoreLimit > 0 {
runtime.GOMAXPROCS(int(config.CoreLimit)) runtime.GOMAXPROCS(int(config.CoreLimit))
} else {
runtime.GOMAXPROCS(runtime.NumCPU())
} }
} }

3
benchmark/worker/benchmark_server.go
View File

@ -70,6 +70,7 @@ func printServerConfig(config *testpb.ServerConfig) {
// - core list // - core list
grpclog.Printf(" * server type: %v (ignored, always starts sync server)", config.ServerType) grpclog.Printf(" * server type: %v (ignored, always starts sync server)", config.ServerType)
grpclog.Printf(" * async server threads: %v (ignored)", config.AsyncServerThreads) grpclog.Printf(" * async server threads: %v (ignored)", config.AsyncServerThreads)
// TODO: use cores specified by CoreList when setting list of cores is supported in go.
grpclog.Printf(" * core list: %v (ignored)", config.CoreList) grpclog.Printf(" * core list: %v (ignored)", config.CoreList)
grpclog.Printf(" - security params: %v", config.SecurityParams) grpclog.Printf(" - security params: %v", config.SecurityParams)
@ -86,8 +87,8 @@ func startBenchmarkServer(config *testpb.ServerConfig, serverPort int) (*benchma
numOfCores := runtime.NumCPU() numOfCores := runtime.NumCPU()
if config.CoreLimit > 0 { if config.CoreLimit > 0 {
numOfCores = int(config.CoreLimit) numOfCores = int(config.CoreLimit)
runtime.GOMAXPROCS(numOfCores)
} }
runtime.GOMAXPROCS(numOfCores)
var opts []grpc.ServerOption var opts []grpc.ServerOption