opensource/grpc-go
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

server: return UNIMPLEMENTED on receipt of malformed method name (#4464)

Browse Source
This commit is contained in:
Easwar Swaminathan
2021-05-24 17:30:40 -07:00
committed by GitHub
parent c4ed6360a9
commit 728364accf
2 changed files with 18 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
server.go
View File

@ -1590,7 +1590,7 @@ func (s *Server) handleStream(t transport.ServerTransport, stream *transport.Str
trInfo.tr.SetError()
}
errDesc := fmt.Sprintf("malformed method name: %q", stream.Method())
if err := t.WriteStatus(stream, status.New(codes.ResourceExhausted, errDesc)); err != nil {
if err := t.WriteStatus(stream, status.New(codes.Unimplemented, errDesc)); err != nil {
if trInfo != nil {
trInfo.tr.LazyLog(&fmtStringer{"%v", []interface{}{err}}, true)
trInfo.tr.SetError()

17
test/end2end_test.go
View File

@ -6347,6 +6347,23 @@ func testServiceConfigMaxMsgSizeTD(t *testing.T, e env) {
}
}
// TestMalformedStreamMethod starts a test server and sends an RPC with a
// malformed method name. The server should respond with an UNIMPLEMENTED status
// code in this case.
func (s) TestMalformedStreamMethod(t *testing.T) {
const testMethod = "a-method-name-without-any-slashes"
te := newTest(t, tcpClearRREnv)
te.startServer(nil)
defer te.tearDown()
ctx, cancel := context.WithTimeout(context.Background(), defaultTestTimeout)
defer cancel()
err := te.clientConn().Invoke(ctx, testMethod, nil, nil)
if gotCode := status.Code(err); gotCode != codes.Unimplemented {
t.Fatalf("Invoke with method %q, got code %s, want %s", testMethod, gotCode, codes.Unimplemented)
}
}
func (s) TestMethodFromServerStream(t *testing.T) {
const testMethod = "/package.service/method"
e := tcpClearRREnv