From 577b4b0d4c48abb73df9570ca5eb6151b70e334c Mon Sep 17 00:00:00 2001 From: Menghan Li Date: Fri, 13 May 2016 10:36:50 -0700 Subject: [PATCH] Address review comments --- benchmark/stats/histogram.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/benchmark/stats/histogram.go b/benchmark/stats/histogram.go index 140b6ea4..c0e9a193 100644 --- a/benchmark/stats/histogram.go +++ b/benchmark/stats/histogram.go @@ -12,9 +12,6 @@ import ( // Histogram accumulates values in the form of a histogram with // exponentially increased bucket sizes. -// The first bucket (with index 0) is [0, n) where n = baseBucketSize. -// Bucket i (i>=1) contains [n * m^(i-1), n * m^i), where m = 1 + GrowthFactor. -// The type of the values is int64. type Histogram struct { // Count is the total number of values added to the histogram. Count int64 @@ -35,6 +32,10 @@ type Histogram struct { } // HistogramOptions contains the parameters that define the histogram's buckets. +// The first bucket of the created histogram (with index 0) contains [min, min+n) +// where n = BaseBucketSize, min = MinValue. +// Bucket i (i>=1) contains [min + n * m^(i-1), min + n * m^i), where m = 1+GrowthFactor. +// The type of the values is int64. type HistogramOptions struct { // NumBuckets is the number of buckets. NumBuckets int @@ -47,7 +48,7 @@ type HistogramOptions struct { MinValue int64 } -// HistogramBucket is one histogram bucket. +// HistogramBucket represents one histogram bucket. type HistogramBucket struct { // LowBound is the lower bound of the bucket. LowBound float64