Bug fix: Updated handlePing to not respond to acks

2016-10-13 17:34:12 -07:00
parent 9eaed1a74a
commit 37fb89efad
2 changed files with 6 additions and 0 deletions
--- a/transport/http2_client.go
+++ b/transport/http2_client.go
@ -790,6 +790,9 @@ func (t *http2Client) handleSettings(f *http2.SettingsFrame) {
 }

 func (t *http2Client) handlePing(f *http2.PingFrame) {
+	if f.IsAck() { // Do nothing.
+		return
+	}
 	pingAck := &ping{ack: true}
 	copy(pingAck.data[:], f.Data[:])
 	t.controlBuf.put(pingAck)
--- a/transport/http2_server.go
+++ b/transport/http2_server.go
@ -405,6 +405,9 @@ func (t *http2Server) handleSettings(f *http2.SettingsFrame) {
 }

 func (t *http2Server) handlePing(f *http2.PingFrame) {
+	if f.IsAck() { // Do nothing.
+		return
+	}
 	pingAck := &ping{ack: true}
 	copy(pingAck.data[:], f.Data[:])
 	t.controlBuf.put(pingAck)