From 2259ee6f1a16ff0bb8776e5d2476a2b12e8fda04 Mon Sep 17 00:00:00 2001 From: Menghan Li Date: Thu, 7 Feb 2019 13:44:42 -0800 Subject: [PATCH] makefile: remove testappengine from make all (#2621) Since it requires goapp. --- CONTRIBUTING.md | 1 + Makefile | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 0863eb26..ca34e8aa 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -31,6 +31,7 @@ How to get your contributions merged smoothly and quickly. - `make vet` to catch vet errors - `make test` to run the tests - `make testrace` to run tests in race mode + - optional `make testappengine` to run tests with appengine - Exceptions to the rules can be made if there's a compelling reason for doing so. diff --git a/Makefile b/Makefile index 41a754f9..db982aab 100644 --- a/Makefile +++ b/Makefile @@ -1,4 +1,4 @@ -all: vet test testrace testappengine +all: vet test testrace build: deps go build google.golang.org/grpc/...