From 325a0c20617a510eeddded9ce2475ffd6c0fade3 Mon Sep 17 00:00:00 2001 From: "Mark D. Roth" Date: Mon, 9 Jan 2017 12:59:10 -0800 Subject: [PATCH 1/2] Update comment. --- rpc_util.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/rpc_util.go b/rpc_util.go index 2619d396..0c75d234 100644 --- a/rpc_util.go +++ b/rpc_util.go @@ -486,11 +486,11 @@ type MethodConfig struct { // then the other will be used. If neither is set, then the RPC has no deadline. Timeout time.Duration // MaxReqSize is the maximum allowed payload size for an individual request in a - // stream (client->server) in bytes. The size which is measured is the serialized, - // uncompressed payload in bytes. The actual value used is the minumum of the value - // specified here and the value set by the application via the gRPC client API. If - // either one is not set, then the other will be used. If neither is set, then the - // built-in default is used. + // stream (client->server) in bytes. The size which is measured is the serialized + // payload after per-message compression (but before stream compression) in bytes. + // The actual value used is the minumum of the value specified here and the value set + // by the application via the gRPC client API. If either one is not set, then the other + // will be used. If neither is set, then the built-in default is used. // TODO: support this. MaxReqSize uint64 // MaxRespSize is the maximum allowed payload size for an individual response in a From 6e0ace39feadc9c812cd5191203d99c2c7ce12cd Mon Sep 17 00:00:00 2001 From: "Mark D. Roth" Date: Thu, 26 Jan 2017 14:43:08 -0800 Subject: [PATCH 2/2] Change max message size fields from uint64 to uint32. --- rpc_util.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rpc_util.go b/rpc_util.go index 0c75d234..fa69d58c 100644 --- a/rpc_util.go +++ b/rpc_util.go @@ -492,11 +492,11 @@ type MethodConfig struct { // by the application via the gRPC client API. If either one is not set, then the other // will be used. If neither is set, then the built-in default is used. // TODO: support this. - MaxReqSize uint64 + MaxReqSize uint32 // MaxRespSize is the maximum allowed payload size for an individual response in a // stream (server->client) in bytes. // TODO: support this. - MaxRespSize uint64 + MaxRespSize uint32 } // ServiceConfig is provided by the service provider and contains parameters for how