diff --git a/benchmark/benchmark.go b/benchmark/benchmark.go index be294734..83d5f5bd 100644 --- a/benchmark/benchmark.go +++ b/benchmark/benchmark.go @@ -37,15 +37,14 @@ Package benchmark implements the building blocks to setup end-to-end gRPC benchm package benchmark import ( - "golang.org/x/net/context" "io" "math" "net" - + + "golang.org/x/net/context" "google.golang.org/grpc" testpb "google.golang.org/grpc/benchmark/grpc_testing" "google.golang.org/grpc/grpclog" - ) func newPayload(t testpb.PayloadType, size int) *testpb.Payload { @@ -121,8 +120,8 @@ func DoUnaryCall(tc testpb.TestServiceClient, reqSize, respSize int) { } } -// DoStreamingcall performs a streaming RPC with given stub and request and response size.client side -func DoStreamingCall(stream testpb.TestService_StreamingCallClient, tc testpb.TestServiceClient, reqSize, respSize int) { +// DoStreamingRoundTrip performs a round trip for a single streaming rpc. +func DoStreamingRoundTrip(tc testpb.TestServiceClient, stream testpb.TestService_StreamingCallClient, reqSize, respSize int) { pl := newPayload(testpb.PayloadType_COMPRESSABLE, reqSize) req := &testpb.SimpleRequest{ ResponseType: pl.Type, @@ -130,10 +129,10 @@ func DoStreamingCall(stream testpb.TestService_StreamingCallClient, tc testpb.Te Payload: pl, } if err := stream.Send(req); err != nil { - grpclog.Fatalf("%v.StreamingCall()= %v ", tc, err) + grpclog.Fatalf("%v.StreamingCall(_)=_, %v: ", tc, err) } if _, err := stream.Recv(); err != nil { - grpclog.Fatal("%v.StreamingCall()= %v", tc, err) + grpclog.Fatal("%v.StreamingCall(_)=_, %v: ", tc, err) } } diff --git a/benchmark/benchmark_test.go b/benchmark/benchmark_test.go index 696ce524..76e99688 100644 --- a/benchmark/benchmark_test.go +++ b/benchmark/benchmark_test.go @@ -64,11 +64,11 @@ func runStream(b *testing.B, maxConcurrentCalls int) { tc := testpb.NewTestServiceClient(conn) stream, err := tc.StreamingCall(context.Background()) if err != nil { - grpclog.Fatalf("%v.StreamingCall()=%v", tc, err) + grpclog.Fatalf("%v.StreamingCall(_)=_,%v: ", tc, err) } // Warm up connection. for i := 0; i < 10; i++ { - streamCaller(stream, tc) + streamCaller(tc, stream) } ch := make(chan int, maxConcurrentCalls*4) @@ -83,7 +83,7 @@ func runStream(b *testing.B, maxConcurrentCalls int) { go func() { for _ = range ch { start := time.Now() - streamCaller(stream, tc) + streamCaller(tc, stream) elapse := time.Since(start) mu.Lock() s.Add(elapse) @@ -105,8 +105,8 @@ func unaryCaller(client testpb.TestServiceClient) { DoUnaryCall(client, 1, 1) } -func streamCaller(stream testpb.TestService_StreamingCallClient, client testpb.TestServiceClient) { - DoStreamingCall(stream, client, 1, 1) +func streamCaller(client testpb.TestServiceClient, stream testpb.TestService_StreamingCallClient) { + DoStreamingRoundTrip(client, stream, 1, 1) } func BenchmarkClientStreamc1(b *testing.B) { diff --git a/benchmark/client/main.go b/benchmark/client/main.go index 44e0fbd5..fdb32233 100644 --- a/benchmark/client/main.go +++ b/benchmark/client/main.go @@ -28,8 +28,8 @@ func unaryCaller(client testpb.TestServiceClient) { benchmark.DoUnaryCall(client, 1, 1) } -func streamCaller(stream testpb.TestService_StreamingCallClient, client testpb.TestServiceClient) { - benchmark.DoStreamingCall(stream, client, 1, 1) +func streamCaller(client testpb.TestServiceClient, stream testpb.TestService_StreamingCallClient) { + benchmark.DoStreamingRoundTrip(client, stream, 1, 1) } func buildConnection() (s *stats.Stats, conn *grpc.ClientConn, tc testpb.TestServiceClient) { @@ -91,10 +91,10 @@ func closeLoopStream() { s, conn, tc := buildConnection() stream, err := tc.StreamingCall(context.Background()) if err != nil { - grpclog.Fatalf("%v.StreamingCall()=%v", tc, err) + grpclog.Fatalf("%v.StreamingCall(_)=_,%v: ", tc, err) } for i := 0; i < 100; i++ { - streamCaller(stream, tc) + streamCaller(tc, stream) } ch := make(chan int, *maxConcurrentRPCs*4) var ( @@ -107,7 +107,7 @@ func closeLoopStream() { go func() { for _ = range ch { start := time.Now() - streamCaller(stream, tc) + streamCaller(tc, stream) elapse := time.Since(start) mu.Lock() s.Add(elapse)