opensource/grpc-go
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #1028 from apolcyn/reduce_benchmark_allocs

Browse Source 
remove proto object allocs on streaming benchmark server
This commit is contained in:
MakMukhi
2017-02-09 17:35:33 -08:00
committed by GitHub
parent 9b791e0ea3 bcc367f343
commit 0ed6d03467
1 changed files with 19 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
benchmark/benchmark.go
View File

@ -47,7 +47,8 @@ import (
"google.golang.org/grpc/grpclog" "google.golang.org/grpc/grpclog"
) )
func newPayload(t testpb.PayloadType, size int) *testpb.Payload { // Allows reuse of the same testpb.Payload object.
func setPayload(p *testpb.Payload, t testpb.PayloadType, size int) {
if size < 0 { if size < 0 {
grpclog.Fatalf("Requested a response with invalid length %d", size) grpclog.Fatalf("Requested a response with invalid length %d", size)
} }
@ -59,10 +60,15 @@ func newPayload(t testpb.PayloadType, size int) *testpb.Payload {
default: default:
grpclog.Fatalf("Unsupported payload type: %d", t) grpclog.Fatalf("Unsupported payload type: %d", t)
} }
return &testpb.Payload{ p.Type = t
Type: t, p.Body = body
Body: body, return
} }
func newPayload(t testpb.PayloadType, size int) *testpb.Payload {
p := new(testpb.Payload)
setPayload(p, t, size)
return p
} }
type testServer struct { type testServer struct {
@ -75,8 +81,13 @@ func (s *testServer) UnaryCall(ctx context.Context, in *testpb.SimpleRequest) (*
} }
func (s *testServer) StreamingCall(stream testpb.BenchmarkService_StreamingCallServer) error { func (s *testServer) StreamingCall(stream testpb.BenchmarkService_StreamingCallServer) error {
response := &testpb.SimpleResponse{
Payload: new(testpb.Payload),
}
in := new(testpb.SimpleRequest)
for { for {
in, err := stream.Recv() // use ServerStream directly to reuse the same testpb.SimpleRequest object
err := stream.(grpc.ServerStream).RecvMsg(in)
if err == io.EOF { if err == io.EOF {
// read done. // read done.
return nil return nil
@ -84,9 +95,8 @@ func (s *testServer) StreamingCall(stream testpb.BenchmarkService_StreamingCallS
if err != nil { if err != nil {
return err return err
} }
if err := stream.Send(&testpb.SimpleResponse{ setPayload(response.Payload, in.ResponseType, int(in.ResponseSize))
Payload: newPayload(in.ResponseType, int(in.ResponseSize)), if err := stream.Send(response); err != nil {
}); err != nil {
return err return err
} }
} }