From 77204bfdf20f994410e246a68543efe9cb644f98 Mon Sep 17 00:00:00 2001 From: Doug Fawley Date: Fri, 3 Mar 2017 12:48:16 -0800 Subject: [PATCH] Add comment explaining why cancel is not called in success path after client transport is created --- clientconn.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/clientconn.go b/clientconn.go index 459ce0b6..cff53f73 100644 --- a/clientconn.go +++ b/clientconn.go @@ -777,6 +777,8 @@ func (ac *addrConn) resetTransport(closeTransport bool) error { Metadata: ac.addr.Metadata, } newTransport, err := transport.NewClientTransport(ctx, sinfo, ac.dopts.copts) + // Don't call cancel in success path due to a race in Go 1.6: + // https://github.com/golang/go/issues/15078. if err != nil { cancel()