mirror of
https://github.com/grafana/grafana.git
synced 2025-07-28 14:52:36 +08:00

* Add exploration option to node layout * Add hidden node count * Add grid layout option * Fix panning bounds calculation * Add legend with sorting * Allow sorting on any stats or arc value * Fix merge * Make sorting better * Reset focused node on layout change * Refactor limit hook a bit * Disable selected layout button * Don't show markers if only 1 node is hidden * Move legend to the bottom * Fix text backgrounds * Add show in graph layout action in grid layout * Center view on the focused node, fix perf issue when expanding big graph * Limit the node counting * Comment and linting fixes * Bit of code cleanup and comments * Add state for computing layout * Prevent computing map with partial data * Add rollup plugin for worker * Add rollup plugin for worker * Enhance data from worker * Fix perf issues with reduce and object creation * Improve comment * Fix tests * Css fixes * Remove worker plugin * Add comments * Fix test * Add test for exploration * Add test switching to grid layout * Apply suggestions from code review Co-authored-by: Zoltán Bedi <zoltan.bedi@gmail.com> * Remove unused plugin * Fix function name * Remove unused rollup plugin * Review fixes * Fix context menu shown on layout change * Make buttons bigger * Moved NodeGraph to core grafana Co-authored-by: Zoltán Bedi <zoltan.bedi@gmail.com>
266 lines
7.5 KiB
TypeScript
266 lines
7.5 KiB
TypeScript
import React from 'react';
|
|
import { render, screen, fireEvent, waitFor, getByText } from '@testing-library/react';
|
|
import userEvent from '@testing-library/user-event';
|
|
import { NodeGraph } from './NodeGraph';
|
|
import { makeEdgesDataFrame, makeNodesDataFrame } from './utils';
|
|
|
|
jest.mock('./layout.worker.js', () => {
|
|
const { layout } = jest.requireActual('./layout.worker.js');
|
|
class TestWorker {
|
|
constructor() {}
|
|
postMessage(data: any) {
|
|
const { nodes, edges, config } = data;
|
|
setTimeout(() => {
|
|
layout(nodes, edges, config);
|
|
// @ts-ignore
|
|
this.onmessage({ data: { nodes, edges } });
|
|
}, 1);
|
|
}
|
|
}
|
|
return {
|
|
__esModule: true,
|
|
default: TestWorker,
|
|
};
|
|
});
|
|
|
|
describe('NodeGraph', () => {
|
|
it('doesnt fail without any data', async () => {
|
|
render(<NodeGraph dataFrames={[]} getLinks={() => []} />);
|
|
});
|
|
|
|
it('can zoom in and out', async () => {
|
|
render(<NodeGraph dataFrames={[]} getLinks={() => []} />);
|
|
const zoomIn = await screen.findByTitle(/Zoom in/);
|
|
const zoomOut = await screen.findByTitle(/Zoom out/);
|
|
|
|
expect(getScale()).toBe(1);
|
|
userEvent.click(zoomIn);
|
|
expect(getScale()).toBe(1.5);
|
|
userEvent.click(zoomOut);
|
|
expect(getScale()).toBe(1);
|
|
});
|
|
|
|
it('can pan the graph', async () => {
|
|
render(
|
|
<NodeGraph
|
|
dataFrames={[
|
|
makeNodesDataFrame(3),
|
|
makeEdgesDataFrame([
|
|
[0, 1],
|
|
[1, 2],
|
|
]),
|
|
]}
|
|
getLinks={() => []}
|
|
/>
|
|
);
|
|
|
|
await screen.findByLabelText('Node: service:1');
|
|
|
|
panView({ x: 10, y: 10 });
|
|
screen.debug(getSvg());
|
|
// Though we try to pan down 10px we are rendering in straight line 3 nodes so there are bounds preventing
|
|
// as panning vertically
|
|
await waitFor(() => expect(getTranslate()).toEqual({ x: 10, y: 0 }));
|
|
});
|
|
|
|
it('renders with single node', async () => {
|
|
render(<NodeGraph dataFrames={[makeNodesDataFrame(1)]} getLinks={() => []} />);
|
|
const circle = await screen.findByText('', { selector: 'circle' });
|
|
await screen.findByText(/service:0/);
|
|
expect(getXY(circle)).toEqual({ x: 0, y: 0 });
|
|
});
|
|
|
|
it('shows context menu when clicking on node or edge', async () => {
|
|
render(
|
|
<NodeGraph
|
|
dataFrames={[makeNodesDataFrame(2), makeEdgesDataFrame([[0, 1]])]}
|
|
getLinks={(dataFrame) => {
|
|
return [
|
|
{
|
|
title: dataFrame.fields.find((f) => f.name === 'source') ? 'Edge traces' : 'Node traces',
|
|
href: '',
|
|
origin: null,
|
|
target: '_self',
|
|
},
|
|
];
|
|
}}
|
|
/>
|
|
);
|
|
const node = await screen.findByLabelText(/Node: service:0/);
|
|
// This shows warning because there is no position for the click. We cannot add any because we use pageX/Y in the
|
|
// context menu which is experimental (but supported) property and userEvents does not seem to support that
|
|
userEvent.click(node);
|
|
await screen.findByText(/Node traces/);
|
|
|
|
const edge = await screen.findByLabelText(/Edge from/);
|
|
userEvent.click(edge);
|
|
await screen.findByText(/Edge traces/);
|
|
});
|
|
|
|
it('lays out 3 nodes in single line', async () => {
|
|
render(
|
|
<NodeGraph
|
|
dataFrames={[
|
|
makeNodesDataFrame(3),
|
|
makeEdgesDataFrame([
|
|
[0, 1],
|
|
[1, 2],
|
|
]),
|
|
]}
|
|
getLinks={() => []}
|
|
/>
|
|
);
|
|
|
|
await expectNodePositionCloseTo('service:0', { x: -221, y: 0 });
|
|
await expectNodePositionCloseTo('service:1', { x: -21, y: 0 });
|
|
await expectNodePositionCloseTo('service:2', { x: 221, y: 0 });
|
|
});
|
|
|
|
it('lays out first children on one vertical line', async () => {
|
|
render(
|
|
<NodeGraph
|
|
dataFrames={[
|
|
makeNodesDataFrame(3),
|
|
makeEdgesDataFrame([
|
|
[0, 1],
|
|
[0, 2],
|
|
]),
|
|
]}
|
|
getLinks={() => []}
|
|
/>
|
|
);
|
|
|
|
// Should basically look like <
|
|
await expectNodePositionCloseTo('service:0', { x: -100, y: 0 });
|
|
await expectNodePositionCloseTo('service:1', { x: 100, y: -100 });
|
|
await expectNodePositionCloseTo('service:2', { x: 100, y: 100 });
|
|
});
|
|
|
|
it('limits the number of nodes shown and shows a warning', async () => {
|
|
render(
|
|
<NodeGraph
|
|
dataFrames={[
|
|
makeNodesDataFrame(5),
|
|
makeEdgesDataFrame([
|
|
[0, 1],
|
|
[0, 2],
|
|
[2, 3],
|
|
[3, 4],
|
|
]),
|
|
]}
|
|
getLinks={() => []}
|
|
nodeLimit={2}
|
|
/>
|
|
);
|
|
|
|
const nodes = await screen.findAllByLabelText(/Node: service:\d/);
|
|
expect(nodes.length).toBe(2);
|
|
screen.getByLabelText(/Nodes hidden warning/);
|
|
|
|
const markers = await screen.findAllByLabelText(/Hidden nodes marker: \d/);
|
|
expect(markers.length).toBe(1);
|
|
});
|
|
|
|
it('allows expanding the nodes when limiting visible nodes', async () => {
|
|
render(
|
|
<NodeGraph
|
|
dataFrames={[
|
|
makeNodesDataFrame(5),
|
|
makeEdgesDataFrame([
|
|
[0, 1],
|
|
[1, 2],
|
|
[2, 3],
|
|
[3, 4],
|
|
]),
|
|
]}
|
|
getLinks={() => []}
|
|
nodeLimit={3}
|
|
/>
|
|
);
|
|
|
|
const node = await screen.findByLabelText(/Node: service:0/);
|
|
expect(node).toBeInTheDocument();
|
|
|
|
const marker = await screen.findByLabelText(/Hidden nodes marker: 3/);
|
|
userEvent.click(marker);
|
|
|
|
expect(screen.queryByLabelText(/Node: service:0/)).not.toBeInTheDocument();
|
|
expect(screen.getByLabelText(/Node: service:4/)).toBeInTheDocument();
|
|
|
|
const nodes = await screen.findAllByLabelText(/Node: service:\d/);
|
|
expect(nodes.length).toBe(3);
|
|
});
|
|
|
|
it('can switch to grid layout', async () => {
|
|
render(
|
|
<NodeGraph
|
|
dataFrames={[
|
|
makeNodesDataFrame(3),
|
|
makeEdgesDataFrame([
|
|
[0, 1],
|
|
[1, 2],
|
|
]),
|
|
]}
|
|
getLinks={() => []}
|
|
nodeLimit={3}
|
|
/>
|
|
);
|
|
|
|
const button = await screen.findByTitle(/Grid layout/);
|
|
userEvent.click(button);
|
|
|
|
await expectNodePositionCloseTo('service:0', { x: -180, y: -60 });
|
|
await expectNodePositionCloseTo('service:1', { x: -60, y: -60 });
|
|
await expectNodePositionCloseTo('service:2', { x: 60, y: -60 });
|
|
});
|
|
});
|
|
|
|
async function expectNodePositionCloseTo(node: string, pos: { x: number; y: number }) {
|
|
const nodePos = await getNodeXY(node);
|
|
expect(nodePos.x).toBeCloseTo(pos.x, -1);
|
|
expect(nodePos.y).toBeCloseTo(pos.y, -1);
|
|
}
|
|
|
|
async function getNodeXY(node: string) {
|
|
const group = await screen.findByLabelText(new RegExp(`Node: ${node}`));
|
|
const circle = getByText(group, '', { selector: 'circle' });
|
|
return getXY(circle);
|
|
}
|
|
|
|
function panView(toPos: { x: number; y: number }) {
|
|
const svg = getSvg();
|
|
fireEvent(svg, new MouseEvent('mousedown', { clientX: 0, clientY: 0 }));
|
|
fireEvent(document, new MouseEvent('mousemove', { clientX: toPos.x, clientY: toPos.y }));
|
|
fireEvent(document, new MouseEvent('mouseup'));
|
|
}
|
|
|
|
function getSvg() {
|
|
return screen.getAllByText('', { selector: 'svg' })[0];
|
|
}
|
|
|
|
function getTransform() {
|
|
const svg = getSvg();
|
|
const group = svg.children[0] as SVGElement;
|
|
return group.style.getPropertyValue('transform');
|
|
}
|
|
|
|
function getScale() {
|
|
const scale = getTransform().match(/scale\(([\d\.]+)\)/)![1];
|
|
return parseFloat(scale);
|
|
}
|
|
|
|
function getTranslate() {
|
|
const matches = getTransform().match(/translate\((\d+)px, (\d+)px\)/);
|
|
return {
|
|
x: parseFloat(matches![1]),
|
|
y: parseFloat(matches![2]),
|
|
};
|
|
}
|
|
|
|
function getXY(e: Element) {
|
|
return {
|
|
x: parseFloat(e.attributes.getNamedItem('cx')?.value || ''),
|
|
y: parseFloat(e.attributes.getNamedItem('cy')?.value || ''),
|
|
};
|
|
}
|