mirror of
https://github.com/grafana/grafana.git
synced 2025-08-03 02:42:22 +08:00

* update react 18 related deps * fix some types * make sure we're on react-router-dom >= 5.3.3 * Use new root API * Remove StrictMode for now - react 18 double rendering causes issues * fix + ignore some @grafana/ui types * fix some more types * use renderHook from @testing-library/react in almost all cases * fix storybook types * rewrite useDashboardSave to not use useEffect * make props optional * only render if props are provided * add correct type for useCallback * make resourcepicker tests more robust * fix ModalManager rendering * fix some more unit tests * store the click coordinates in a ref as setState is NOT synchronous * fix remaining e2e tests * rewrite dashboardpage tests to avoid act warnings * undo lint ignores * fix ExpanderCell types * set SymbolCell type correctly * fix QueryAndExpressionsStep * looks like the types were actually wrong instead :D * undo this for now... * remove spinner waits * more robust tests * rewrite errorboundary test to not explicitly count the number of renders * make urlParam expect async * increase timeout in waitFor * revert ExplorePage test changes * Update public/app/features/dashboard/containers/DashboardPage.test.tsx Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * Update public/app/features/dashboard/containers/PublicDashboardPage.test.tsx Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * Update public/app/features/dashboard/containers/PublicDashboardPage.test.tsx Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * Update public/app/features/dashboard/containers/PublicDashboardPage.test.tsx Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * skip fakeTimer test, ignore table types for now + other review comments * update package peerDeps * small tweak to resourcepicker test * update lockfile... * increase timeout in sharepublicdashboard tests * ensure ExplorePaneContainer passes correct queries to initializeExplore * fix LokiContextUI test * fix unit tests * make importDashboard flow more consistent * wait for dashboard name before continuing * more test fixes * readd dashboard name to variable e2e tests * wait for switches to be enabled before clicking * fix modal rendering * don't use @testing-library/dom directly * quick fix for rendering of panels in firefox * make PromQueryField test more robust * don't wait for chartData - in react 18 this can happen before the wait code even gets executed --------- Co-authored-by: kay delaney <kay@grafana.com> Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>
85 lines
2.8 KiB
TypeScript
85 lines
2.8 KiB
TypeScript
import { renderHook } from '@testing-library/react';
|
|
import React, { PropsWithChildren } from 'react';
|
|
import { from } from 'rxjs';
|
|
|
|
import { getDefaultTimeRange } from '@grafana/data';
|
|
|
|
import { ElasticsearchProvider } from '../components/QueryEditor/ElasticsearchQueryContext';
|
|
import { ElasticDatasource } from '../datasource';
|
|
import { defaultBucketAgg, defaultMetricAgg } from '../queryDef';
|
|
import { ElasticsearchQuery, MetricAggregationType, BucketAggregationType } from '../types';
|
|
|
|
import { useFields } from './useFields';
|
|
|
|
describe('useFields hook', () => {
|
|
// TODO: If we move the field type to the configuration objects as described in the hook's source
|
|
// we can stop testing for getField to be called with the correct parameters.
|
|
it("returns a function that calls datasource's getFields with the correct parameters", async () => {
|
|
const timeRange = getDefaultTimeRange();
|
|
const query: ElasticsearchQuery = {
|
|
refId: 'A',
|
|
query: '',
|
|
metrics: [defaultMetricAgg()],
|
|
bucketAggs: [defaultBucketAgg()],
|
|
};
|
|
|
|
const getFields: ElasticDatasource['getFields'] = jest.fn(() => from([[]]));
|
|
|
|
const wrapper = ({ children }: PropsWithChildren<{}>) => (
|
|
<ElasticsearchProvider
|
|
datasource={{ getFields } as ElasticDatasource}
|
|
query={query}
|
|
range={timeRange}
|
|
onChange={() => {}}
|
|
onRunQuery={() => {}}
|
|
>
|
|
{children}
|
|
</ElasticsearchProvider>
|
|
);
|
|
|
|
//
|
|
// METRIC AGGREGATIONS
|
|
//
|
|
// Cardinality works on every kind of data
|
|
const { result, rerender } = renderHook(
|
|
(aggregationType: BucketAggregationType | MetricAggregationType) => useFields(aggregationType),
|
|
{ wrapper, initialProps: 'cardinality' }
|
|
);
|
|
result.current();
|
|
expect(getFields).toHaveBeenLastCalledWith([], timeRange);
|
|
|
|
// All other metric aggregations only work on numbers
|
|
rerender('avg');
|
|
result.current();
|
|
expect(getFields).toHaveBeenLastCalledWith(['number'], timeRange);
|
|
|
|
//
|
|
// BUCKET AGGREGATIONS
|
|
//
|
|
// Date Histrogram only works on dates
|
|
rerender('date_histogram');
|
|
result.current();
|
|
expect(getFields).toHaveBeenLastCalledWith(['date'], timeRange);
|
|
|
|
// Histrogram only works on numbers
|
|
rerender('histogram');
|
|
result.current();
|
|
expect(getFields).toHaveBeenLastCalledWith(['number'], timeRange);
|
|
|
|
// Geohash Grid only works on geo_point data
|
|
rerender('geohash_grid');
|
|
result.current();
|
|
expect(getFields).toHaveBeenLastCalledWith(['geo_point'], timeRange);
|
|
|
|
// All other bucket aggregation work on any kind of data
|
|
rerender('terms');
|
|
result.current();
|
|
expect(getFields).toHaveBeenLastCalledWith([], timeRange);
|
|
|
|
// top_metrics work on only on numeric data in 7.7
|
|
rerender('top_metrics');
|
|
result.current();
|
|
expect(getFields).toHaveBeenLastCalledWith(['number'], timeRange);
|
|
});
|
|
});
|