mirror of
https://github.com/grafana/grafana.git
synced 2025-09-20 00:00:43 +08:00

* update react 18 related deps * fix some types * make sure we're on react-router-dom >= 5.3.3 * Use new root API * Remove StrictMode for now - react 18 double rendering causes issues * fix + ignore some @grafana/ui types * fix some more types * use renderHook from @testing-library/react in almost all cases * fix storybook types * rewrite useDashboardSave to not use useEffect * make props optional * only render if props are provided * add correct type for useCallback * make resourcepicker tests more robust * fix ModalManager rendering * fix some more unit tests * store the click coordinates in a ref as setState is NOT synchronous * fix remaining e2e tests * rewrite dashboardpage tests to avoid act warnings * undo lint ignores * fix ExpanderCell types * set SymbolCell type correctly * fix QueryAndExpressionsStep * looks like the types were actually wrong instead :D * undo this for now... * remove spinner waits * more robust tests * rewrite errorboundary test to not explicitly count the number of renders * make urlParam expect async * increase timeout in waitFor * revert ExplorePage test changes * Update public/app/features/dashboard/containers/DashboardPage.test.tsx Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * Update public/app/features/dashboard/containers/PublicDashboardPage.test.tsx Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * Update public/app/features/dashboard/containers/PublicDashboardPage.test.tsx Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * Update public/app/features/dashboard/containers/PublicDashboardPage.test.tsx Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * skip fakeTimer test, ignore table types for now + other review comments * update package peerDeps * small tweak to resourcepicker test * update lockfile... * increase timeout in sharepublicdashboard tests * ensure ExplorePaneContainer passes correct queries to initializeExplore * fix LokiContextUI test * fix unit tests * make importDashboard flow more consistent * wait for dashboard name before continuing * more test fixes * readd dashboard name to variable e2e tests * wait for switches to be enabled before clicking * fix modal rendering * don't use @testing-library/dom directly * quick fix for rendering of panels in firefox * make PromQueryField test more robust * don't wait for chartData - in react 18 this can happen before the wait code even gets executed --------- Co-authored-by: kay delaney <kay@grafana.com> Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>
275 lines
8.1 KiB
TypeScript
275 lines
8.1 KiB
TypeScript
import { renderHook, waitFor } from '@testing-library/react';
|
|
import { setupServer } from 'msw/node';
|
|
import React from 'react';
|
|
import { Provider } from 'react-redux';
|
|
|
|
import 'whatwg-fetch';
|
|
|
|
import { DataSourceJsonData, DataSourceSettings } from '@grafana/data';
|
|
import { config, setBackendSrv } from '@grafana/runtime';
|
|
import { backendSrv } from 'app/core/services/backend_srv';
|
|
import { AlertManagerDataSourceJsonData } from 'app/plugins/datasource/alertmanager/types';
|
|
|
|
import { mockDataSource, mockDataSourcesStore, mockStore } from '../mocks';
|
|
import { mockAlertmanagersResponse } from '../mocks/alertmanagerApi';
|
|
|
|
import { useExternalDataSourceAlertmanagers } from './useExternalAmSelector';
|
|
|
|
const server = setupServer();
|
|
|
|
beforeAll(() => {
|
|
setBackendSrv(backendSrv);
|
|
server.listen({ onUnhandledRequest: 'error' });
|
|
});
|
|
|
|
beforeEach(() => {
|
|
server.resetHandlers();
|
|
});
|
|
|
|
afterAll(() => {
|
|
server.close();
|
|
});
|
|
|
|
describe('useExternalDataSourceAlertmanagers', () => {
|
|
it('Should merge data sources information from config and api responses', async () => {
|
|
// Arrange
|
|
const { dsSettings, dsInstanceSettings } = setupAlertmanagerDataSource({ url: 'http://grafana.com' });
|
|
|
|
config.datasources = {
|
|
'External Alertmanager': dsInstanceSettings,
|
|
};
|
|
|
|
const store = mockDataSourcesStore({
|
|
dataSources: [dsSettings],
|
|
});
|
|
|
|
mockAlertmanagersResponse(server, { data: { activeAlertManagers: [], droppedAlertManagers: [] } });
|
|
|
|
const wrapper = ({ children }: React.PropsWithChildren<{}>) => <Provider store={store}>{children}</Provider>;
|
|
|
|
// Act
|
|
const { result } = renderHook(() => useExternalDataSourceAlertmanagers(), { wrapper });
|
|
await waitFor(() => {
|
|
// Assert
|
|
const { current } = result;
|
|
|
|
expect(current).toHaveLength(1);
|
|
expect(current[0].dataSource.uid).toBe('1');
|
|
expect(current[0].url).toBe('http://grafana.com');
|
|
});
|
|
});
|
|
|
|
it('Should have active state if available in the activeAlertManagers', async () => {
|
|
// Arrange
|
|
const { dsSettings, dsInstanceSettings } = setupAlertmanagerDataSource({ url: 'http://grafana.com' });
|
|
|
|
config.datasources = {
|
|
'External Alertmanager': dsInstanceSettings,
|
|
};
|
|
|
|
const store = mockStore((state) => {
|
|
state.dataSources.dataSources = [dsSettings];
|
|
});
|
|
|
|
mockAlertmanagersResponse(server, {
|
|
data: {
|
|
activeAlertManagers: [{ url: 'http://grafana.com/api/v2/alerts' }],
|
|
droppedAlertManagers: [],
|
|
},
|
|
});
|
|
|
|
const wrapper = ({ children }: React.PropsWithChildren<{}>) => <Provider store={store}>{children}</Provider>;
|
|
|
|
// Act
|
|
const { result } = renderHook(() => useExternalDataSourceAlertmanagers(), { wrapper });
|
|
await waitFor(() => {
|
|
// Assert
|
|
const { current } = result;
|
|
|
|
expect(current).toHaveLength(1);
|
|
expect(current[0].status).toBe('active');
|
|
expect(current[0].statusInconclusive).toBe(false);
|
|
});
|
|
});
|
|
|
|
it('Should have dropped state if available in the droppedAlertManagers', async () => {
|
|
// Arrange
|
|
const { dsSettings, dsInstanceSettings } = setupAlertmanagerDataSource({ url: 'http://grafana.com' });
|
|
|
|
config.datasources = {
|
|
'External Alertmanager': dsInstanceSettings,
|
|
};
|
|
|
|
const store = mockStore((state) => {
|
|
state.dataSources.dataSources = [dsSettings];
|
|
});
|
|
|
|
mockAlertmanagersResponse(server, {
|
|
data: {
|
|
activeAlertManagers: [],
|
|
droppedAlertManagers: [{ url: 'http://grafana.com/api/v2/alerts' }],
|
|
},
|
|
});
|
|
|
|
const wrapper = ({ children }: React.PropsWithChildren<{}>) => <Provider store={store}>{children}</Provider>;
|
|
|
|
// Act
|
|
const { result } = renderHook(() => useExternalDataSourceAlertmanagers(), { wrapper });
|
|
|
|
await waitFor(() => {
|
|
// Assert
|
|
const { current } = result;
|
|
|
|
expect(current).toHaveLength(1);
|
|
expect(current[0].status).toBe('dropped');
|
|
expect(current[0].statusInconclusive).toBe(false);
|
|
});
|
|
});
|
|
|
|
it('Should have pending state if not available neither in dropped nor in active alertManagers', async () => {
|
|
// Arrange
|
|
const { dsSettings, dsInstanceSettings } = setupAlertmanagerDataSource();
|
|
|
|
config.datasources = {
|
|
'External Alertmanager': dsInstanceSettings,
|
|
};
|
|
|
|
const store = mockStore((state) => {
|
|
state.dataSources.dataSources = [dsSettings];
|
|
});
|
|
|
|
mockAlertmanagersResponse(server, {
|
|
data: {
|
|
activeAlertManagers: [],
|
|
droppedAlertManagers: [],
|
|
},
|
|
});
|
|
|
|
const wrapper = ({ children }: React.PropsWithChildren<{}>) => <Provider store={store}>{children}</Provider>;
|
|
|
|
// Act
|
|
const { result } = renderHook(() => useExternalDataSourceAlertmanagers(), { wrapper });
|
|
|
|
await waitFor(() => {
|
|
// Assert
|
|
const { current } = result;
|
|
|
|
expect(current).toHaveLength(1);
|
|
expect(current[0].status).toBe('pending');
|
|
expect(current[0].statusInconclusive).toBe(false);
|
|
});
|
|
});
|
|
|
|
it('Should match Alertmanager url when datasource url does not have protocol specified', async () => {
|
|
// Arrange
|
|
const { dsSettings, dsInstanceSettings } = setupAlertmanagerDataSource({ url: 'localhost:9093' });
|
|
|
|
config.datasources = {
|
|
'External Alertmanager': dsInstanceSettings,
|
|
};
|
|
|
|
const store = mockStore((state) => {
|
|
state.dataSources.dataSources = [dsSettings];
|
|
});
|
|
|
|
mockAlertmanagersResponse(server, {
|
|
data: {
|
|
activeAlertManagers: [{ url: 'http://localhost:9093/api/v2/alerts' }],
|
|
droppedAlertManagers: [],
|
|
},
|
|
});
|
|
|
|
const wrapper = ({ children }: React.PropsWithChildren<{}>) => <Provider store={store}>{children}</Provider>;
|
|
|
|
// Act
|
|
const { result } = renderHook(() => useExternalDataSourceAlertmanagers(), { wrapper });
|
|
|
|
await waitFor(() => {
|
|
// Assert
|
|
const { current } = result;
|
|
|
|
expect(current).toHaveLength(1);
|
|
expect(current[0].status).toBe('active');
|
|
expect(current[0].url).toBe('localhost:9093');
|
|
});
|
|
});
|
|
|
|
it('Should have inconclusive state when there are many Alertmanagers of the same URL', async () => {
|
|
// Arrange
|
|
mockAlertmanagersResponse(server, {
|
|
data: {
|
|
activeAlertManagers: [{ url: 'http://grafana.com/api/v2/alerts' }, { url: 'http://grafana.com/api/v2/alerts' }],
|
|
droppedAlertManagers: [],
|
|
},
|
|
});
|
|
|
|
const { dsSettings, dsInstanceSettings } = setupAlertmanagerDataSource({ url: 'http://grafana.com' });
|
|
|
|
config.datasources = {
|
|
'External Alertmanager': dsInstanceSettings,
|
|
};
|
|
|
|
const store = mockStore((state) => {
|
|
state.dataSources.dataSources = [dsSettings];
|
|
});
|
|
|
|
const wrapper = ({ children }: React.PropsWithChildren<{}>) => <Provider store={store}>{children}</Provider>;
|
|
|
|
// Act
|
|
const { result } = renderHook(() => useExternalDataSourceAlertmanagers(), {
|
|
wrapper,
|
|
});
|
|
|
|
await waitFor(() => {
|
|
// Assert
|
|
expect(result.current).toHaveLength(1);
|
|
expect(result.current[0].status).toBe('active');
|
|
expect(result.current[0].statusInconclusive).toBe(true);
|
|
});
|
|
});
|
|
});
|
|
|
|
function setupAlertmanagerDataSource(partialDsSettings?: Partial<DataSourceSettings<AlertManagerDataSourceJsonData>>) {
|
|
const dsCommonConfig = {
|
|
uid: '1',
|
|
name: 'External Alertmanager',
|
|
type: 'alertmanager',
|
|
jsonData: { handleGrafanaManagedAlerts: true } as AlertManagerDataSourceJsonData,
|
|
};
|
|
|
|
const dsInstanceSettings = mockDataSource(dsCommonConfig);
|
|
|
|
const dsSettings = mockApiDataSource({
|
|
...dsCommonConfig,
|
|
...partialDsSettings,
|
|
});
|
|
|
|
return { dsSettings, dsInstanceSettings };
|
|
}
|
|
|
|
function mockApiDataSource(partial: Partial<DataSourceSettings<DataSourceJsonData, {}>> = {}) {
|
|
const dsSettings: DataSourceSettings<DataSourceJsonData, {}> = {
|
|
uid: '1',
|
|
id: 1,
|
|
name: '',
|
|
url: '',
|
|
type: '',
|
|
access: '',
|
|
orgId: 1,
|
|
typeLogoUrl: '',
|
|
typeName: '',
|
|
user: '',
|
|
database: '',
|
|
basicAuth: false,
|
|
isDefault: false,
|
|
basicAuthUser: '',
|
|
jsonData: { handleGrafanaManagedAlerts: true } as AlertManagerDataSourceJsonData,
|
|
secureJsonFields: {},
|
|
readOnly: false,
|
|
withCredentials: false,
|
|
...partial,
|
|
};
|
|
|
|
return dsSettings;
|
|
}
|