mirror of
https://github.com/grafana/grafana.git
synced 2025-08-01 22:43:08 +08:00
6dbe3b555f
Adding support for backend plugin client middlewares. This allows headers in outgoing backend plugin and HTTP requests to be modified using client middlewares. The following client middlewares added: Forward cookies: Will forward incoming HTTP request Cookies to outgoing plugins.Client and HTTP requests if the datasource has enabled forwarding of cookies (keepCookies). Forward OAuth token: Will set OAuth token headers on outgoing plugins.Client and HTTP requests if the datasource has enabled Forward OAuth Identity (oauthPassThru). Clear auth headers: Will clear any outgoing HTTP headers that was part of the incoming HTTP request and used when authenticating to Grafana. The current suggested way to register client middlewares is to have a separate package, pluginsintegration, responsible for bootstrap/instantiate the backend plugin client with middlewares and/or longer term bootstrap/instantiate plugin management. Fixes #54135 Related to #47734 Related to #57870 Related to #41623 Related to #57065
86 lines
2.5 KiB
Go
86 lines
2.5 KiB
Go
package httpclientprovider_test
|
|
|
|
import (
|
|
"net/http"
|
|
"testing"
|
|
|
|
"github.com/grafana/grafana-plugin-sdk-go/backend/httpclient"
|
|
"github.com/grafana/grafana/pkg/infra/httpclient/httpclientprovider"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestForwardedCookiesMiddleware(t *testing.T) {
|
|
tcs := []struct {
|
|
desc string
|
|
allowedCookies []string
|
|
disallowedCookies []string
|
|
expectedCookieHeader string
|
|
}{
|
|
{
|
|
desc: "With nil allowedCookies should not populate Cookie header",
|
|
allowedCookies: nil,
|
|
expectedCookieHeader: "",
|
|
},
|
|
{
|
|
desc: "With empty allowed cookies should not populate Cookie header",
|
|
allowedCookies: []string{},
|
|
expectedCookieHeader: "",
|
|
},
|
|
{
|
|
desc: "When provided with allowed cookies should populate Cookie header",
|
|
allowedCookies: []string{"c1", "c3"},
|
|
expectedCookieHeader: "c1=1; c3=3",
|
|
},
|
|
{
|
|
desc: "When provided with allowed and not allowed cookies should populate Cookie header",
|
|
allowedCookies: []string{"c1", "c3"},
|
|
disallowedCookies: []string{"c1"},
|
|
expectedCookieHeader: "c3=3",
|
|
},
|
|
}
|
|
|
|
for _, tc := range tcs {
|
|
t.Run(tc.desc, func(t *testing.T) {
|
|
ctx := &testContext{}
|
|
finalRoundTripper := ctx.createRoundTripper()
|
|
forwarded := []*http.Cookie{
|
|
{Name: "c1", Value: "1"},
|
|
{Name: "c2", Value: "2"},
|
|
{Name: "c3", Value: "3"},
|
|
}
|
|
mw := httpclientprovider.ForwardedCookiesMiddleware(forwarded, tc.allowedCookies, tc.disallowedCookies)
|
|
opts := httpclient.Options{}
|
|
rt := mw.CreateMiddleware(opts, finalRoundTripper)
|
|
require.NotNil(t, rt)
|
|
middlewareName, ok := mw.(httpclient.MiddlewareName)
|
|
require.True(t, ok)
|
|
require.Equal(t, "forwarded-cookies", middlewareName.MiddlewareName())
|
|
|
|
req, err := http.NewRequest(http.MethodGet, "http://", nil)
|
|
require.NoError(t, err)
|
|
res, err := rt.RoundTrip(req)
|
|
require.NoError(t, err)
|
|
require.NotNil(t, res)
|
|
if res.Body != nil {
|
|
require.NoError(t, res.Body.Close())
|
|
}
|
|
require.Len(t, ctx.callChain, 1)
|
|
require.ElementsMatch(t, []string{"final"}, ctx.callChain)
|
|
require.Equal(t, tc.expectedCookieHeader, ctx.req.Header.Get("Cookie"))
|
|
})
|
|
}
|
|
}
|
|
|
|
type testContext struct {
|
|
callChain []string
|
|
req *http.Request
|
|
}
|
|
|
|
func (c *testContext) createRoundTripper() http.RoundTripper {
|
|
return httpclient.RoundTripperFunc(func(req *http.Request) (*http.Response, error) {
|
|
c.callChain = append(c.callChain, "final")
|
|
c.req = req
|
|
return &http.Response{StatusCode: http.StatusOK}, nil
|
|
})
|
|
}
|