mirror of
https://github.com/grafana/grafana.git
synced 2025-09-20 07:44:29 +08:00

* GrafanaUI: add option to close DeleteButton on confirm click * add datasource readOnly info to frontend settings * move isTruthy utility type guard * add generic non-visualization table component * Add correlations settings page * add missing readOnly in mock * Fix typo * avoid reloading correlations after add/remove * use DeepPartial from rhf * validate source data source * fix validation logic * fix navmodel test * add missing readonly property * remove unused styles * handle multiple clicks on elements * better UX for loading states * fix remove handler * add glue icon
216 lines
6.4 KiB
TypeScript
216 lines
6.4 KiB
TypeScript
import { css } from '@emotion/css';
|
|
import { negate } from 'lodash';
|
|
import React, { memo, useCallback, useEffect, useMemo, useState } from 'react';
|
|
import { CellProps, SortByFn } from 'react-table';
|
|
|
|
import { GrafanaTheme2 } from '@grafana/data';
|
|
import { Badge, Button, DeleteButton, HorizontalGroup, LoadingPlaceholder, useStyles2, Alert } from '@grafana/ui';
|
|
import { Page } from 'app/core/components/Page/Page';
|
|
import { contextSrv } from 'app/core/core';
|
|
import { useNavModel } from 'app/core/hooks/useNavModel';
|
|
import { AccessControlAction } from 'app/types';
|
|
|
|
import { AddCorrelationForm } from './Forms/AddCorrelationForm';
|
|
import { EditCorrelationForm } from './Forms/EditCorrelationForm';
|
|
import { EmptyCorrelationsCTA } from './components/EmptyCorrelationsCTA';
|
|
import { Column, Table } from './components/Table';
|
|
import { RemoveCorrelationParams } from './types';
|
|
import { CorrelationData, useCorrelations } from './useCorrelations';
|
|
|
|
const sortDatasource: SortByFn<CorrelationData> = (a, b, column) =>
|
|
a.values[column].name.localeCompare(b.values[column].name);
|
|
|
|
const isSourceReadOnly = ({ source }: Pick<CorrelationData, 'source'>) => source.readOnly;
|
|
|
|
const loaderWrapper = css`
|
|
display: flex;
|
|
justify-content: center;
|
|
`;
|
|
|
|
export default function CorrelationsPage() {
|
|
const navModel = useNavModel('correlations');
|
|
const [isAdding, setIsAdding] = useState(false);
|
|
const { remove, get } = useCorrelations();
|
|
|
|
useEffect(() => {
|
|
get.execute();
|
|
// we only want to fetch data on first render
|
|
// eslint-disable-next-line react-hooks/exhaustive-deps
|
|
}, []);
|
|
|
|
const canWriteCorrelations = contextSrv.hasPermission(AccessControlAction.DataSourcesWrite);
|
|
|
|
const handleAdd = useCallback(() => {
|
|
get.execute();
|
|
setIsAdding(false);
|
|
}, [get]);
|
|
|
|
const handleUpdate = useCallback(() => {
|
|
get.execute();
|
|
}, [get]);
|
|
|
|
const handleRemove = useCallback<(params: RemoveCorrelationParams) => void>(
|
|
async (correlation) => {
|
|
await remove.execute(correlation);
|
|
get.execute();
|
|
},
|
|
[remove, get]
|
|
);
|
|
|
|
const RowActions = useCallback(
|
|
({
|
|
row: {
|
|
original: {
|
|
source: { uid: sourceUID, readOnly },
|
|
uid,
|
|
},
|
|
},
|
|
}: CellProps<CorrelationData, void>) =>
|
|
!readOnly && (
|
|
<DeleteButton
|
|
aria-label="delete correlation"
|
|
onConfirm={() => handleRemove({ sourceUID, uid })}
|
|
closeOnConfirm
|
|
/>
|
|
),
|
|
[handleRemove]
|
|
);
|
|
|
|
const columns = useMemo<Array<Column<CorrelationData>>>(
|
|
() => [
|
|
{
|
|
cell: InfoCell,
|
|
shrink: true,
|
|
visible: (data) => data.some(isSourceReadOnly),
|
|
},
|
|
{
|
|
id: 'source',
|
|
header: 'Source',
|
|
cell: DataSourceCell,
|
|
sortType: sortDatasource,
|
|
},
|
|
{
|
|
id: 'target',
|
|
header: 'Target',
|
|
cell: DataSourceCell,
|
|
sortType: sortDatasource,
|
|
},
|
|
{ id: 'label', header: 'Label', sortType: 'alphanumeric' },
|
|
{
|
|
cell: RowActions,
|
|
shrink: true,
|
|
visible: (data) => canWriteCorrelations && data.some(negate(isSourceReadOnly)),
|
|
},
|
|
],
|
|
[RowActions, canWriteCorrelations]
|
|
);
|
|
|
|
const data = useMemo(() => get.value, [get.value]);
|
|
|
|
const showEmptyListCTA = data?.length === 0 && !isAdding && (!get.error || get.error.status === 404);
|
|
|
|
return (
|
|
<Page navModel={navModel}>
|
|
<Page.Contents>
|
|
<div>
|
|
<HorizontalGroup justify="space-between">
|
|
<div>
|
|
<h4>Correlations</h4>
|
|
<p>Define how data living in different data sources relates to each other.</p>
|
|
</div>
|
|
{canWriteCorrelations && data?.length !== 0 && data !== undefined && !isAdding && (
|
|
<Button icon="plus" onClick={() => setIsAdding(true)}>
|
|
Add new
|
|
</Button>
|
|
)}
|
|
</HorizontalGroup>
|
|
</div>
|
|
|
|
{!data && get.loading && (
|
|
<div className={loaderWrapper}>
|
|
<LoadingPlaceholder text="loading..." />
|
|
</div>
|
|
)}
|
|
|
|
{showEmptyListCTA && <EmptyCorrelationsCTA onClick={() => setIsAdding(true)} />}
|
|
|
|
{
|
|
// This error is not actionable, it'd be nice to have a recovery button
|
|
get.error && get.error.status !== 404 && (
|
|
<Alert severity="error" title="Error fetching correlation data" topSpacing={2}>
|
|
<HorizontalGroup>
|
|
{get.error.data.message ||
|
|
'An unknown error occurred while fetching correlation data. Please try again.'}
|
|
</HorizontalGroup>
|
|
</Alert>
|
|
)
|
|
}
|
|
|
|
{isAdding && <AddCorrelationForm onClose={() => setIsAdding(false)} onCreated={handleAdd} />}
|
|
|
|
{data && data.length >= 1 && (
|
|
<Table
|
|
renderExpandedRow={({ target, source, ...correlation }) => (
|
|
<EditCorrelationForm
|
|
defaultValues={{ sourceUID: source.uid, ...correlation }}
|
|
onUpdated={handleUpdate}
|
|
readOnly={isSourceReadOnly({ source }) || !canWriteCorrelations}
|
|
/>
|
|
)}
|
|
columns={columns}
|
|
data={data}
|
|
getRowId={(correlation) => `${correlation.source.uid}-${correlation.uid}`}
|
|
/>
|
|
)}
|
|
</Page.Contents>
|
|
</Page>
|
|
);
|
|
}
|
|
|
|
const getDatasourceCellStyles = (theme: GrafanaTheme2) => ({
|
|
root: css`
|
|
display: flex;
|
|
align-items: center;
|
|
`,
|
|
dsLogo: css`
|
|
margin-right: ${theme.spacing()};
|
|
height: 16px;
|
|
width: 16px;
|
|
`,
|
|
});
|
|
|
|
const DataSourceCell = memo(
|
|
function DataSourceCell({
|
|
cell: { value },
|
|
}: CellProps<CorrelationData, CorrelationData['source'] | CorrelationData['target']>) {
|
|
const styles = useStyles2(getDatasourceCellStyles);
|
|
|
|
return (
|
|
<span className={styles.root}>
|
|
<img src={value.meta.info.logos.small} className={styles.dsLogo} />
|
|
{value.name}
|
|
</span>
|
|
);
|
|
},
|
|
({ cell: { value } }, { cell: { value: prevValue } }) => {
|
|
return value.type === prevValue.type && value.name === prevValue.name;
|
|
}
|
|
);
|
|
|
|
const noWrap = css`
|
|
white-space: nowrap;
|
|
`;
|
|
|
|
const InfoCell = memo(
|
|
function InfoCell({ ...props }: CellProps<CorrelationData, void>) {
|
|
const readOnly = props.row.original.source.readOnly;
|
|
|
|
if (readOnly) {
|
|
return <Badge text="Read only" color="purple" className={noWrap} />;
|
|
} else {
|
|
return null;
|
|
}
|
|
},
|
|
(props, prevProps) => props.row.original.source.readOnly === prevProps.row.original.source.readOnly
|
|
);
|