mirror of
https://github.com/grafana/grafana.git
synced 2025-07-29 13:22:28 +08:00
d0a80c59f3
By storing render key in remote cache it will enable image renderer to use public facing url or load balancer url to render images and thereby remove the requirement of image renderer having to use the url of the originating Grafana instance when running HA setup (multiple Grafana instances). Fixes #17704 Ref grafana/grafana-image-renderer#91
87 lines
2.4 KiB
Go
87 lines
2.4 KiB
Go
package middleware
|
|
|
|
import (
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/grafana/grafana/pkg/bus"
|
|
"github.com/grafana/grafana/pkg/infra/remotecache"
|
|
m "github.com/grafana/grafana/pkg/models"
|
|
"github.com/grafana/grafana/pkg/services/auth"
|
|
"github.com/grafana/grafana/pkg/setting"
|
|
. "github.com/smartystreets/goconvey/convey"
|
|
macaron "gopkg.in/macaron.v1"
|
|
)
|
|
|
|
func TestRecoveryMiddleware(t *testing.T) {
|
|
setting.ERR_TEMPLATE_NAME = "error-template"
|
|
|
|
Convey("Given an api route that panics", t, func() {
|
|
apiURL := "/api/whatever"
|
|
recoveryScenario(t, "recovery middleware should return json", apiURL, func(sc *scenarioContext) {
|
|
sc.handlerFunc = PanicHandler
|
|
sc.fakeReq("GET", apiURL).exec()
|
|
sc.req.Header.Add("content-type", "application/json")
|
|
|
|
So(sc.resp.Code, ShouldEqual, 500)
|
|
So(sc.respJson["message"], ShouldStartWith, "Internal Server Error - Check the Grafana server logs for the detailed error message.")
|
|
So(sc.respJson["error"], ShouldStartWith, "Server Error")
|
|
})
|
|
})
|
|
|
|
Convey("Given a non-api route that panics", t, func() {
|
|
apiURL := "/whatever"
|
|
recoveryScenario(t, "recovery middleware should return html", apiURL, func(sc *scenarioContext) {
|
|
sc.handlerFunc = PanicHandler
|
|
sc.fakeReq("GET", apiURL).exec()
|
|
|
|
So(sc.resp.Code, ShouldEqual, 500)
|
|
So(sc.resp.Header().Get("content-type"), ShouldEqual, "text/html; charset=UTF-8")
|
|
So(sc.resp.Body.String(), ShouldContainSubstring, "<title>Grafana - Error</title>")
|
|
})
|
|
})
|
|
}
|
|
|
|
func PanicHandler(c *m.ReqContext) {
|
|
panic("Handler has panicked")
|
|
}
|
|
|
|
func recoveryScenario(t *testing.T, desc string, url string, fn scenarioFunc) {
|
|
Convey(desc, func() {
|
|
defer bus.ClearBusHandlers()
|
|
|
|
sc := &scenarioContext{
|
|
url: url,
|
|
}
|
|
|
|
viewsPath, _ := filepath.Abs("../../public/views")
|
|
|
|
sc.m = macaron.New()
|
|
sc.m.Use(Recovery())
|
|
|
|
sc.m.Use(AddDefaultResponseHeaders())
|
|
sc.m.Use(macaron.Renderer(macaron.RenderOptions{
|
|
Directory: viewsPath,
|
|
Delims: macaron.Delims{Left: "[[", Right: "]]"},
|
|
}))
|
|
|
|
sc.userAuthTokenService = auth.NewFakeUserAuthTokenService()
|
|
sc.remoteCacheService = remotecache.NewFakeStore(t)
|
|
|
|
sc.m.Use(GetContextHandler(sc.userAuthTokenService, sc.remoteCacheService, nil))
|
|
// mock out gc goroutine
|
|
sc.m.Use(OrgRedirect())
|
|
|
|
sc.defaultHandler = func(c *m.ReqContext) {
|
|
sc.context = c
|
|
if sc.handlerFunc != nil {
|
|
sc.handlerFunc(sc.context)
|
|
}
|
|
}
|
|
|
|
sc.m.Get(url, sc.defaultHandler)
|
|
|
|
fn(sc)
|
|
})
|
|
}
|