mirror of
https://github.com/grafana/grafana.git
synced 2025-08-06 02:29:33 +08:00
9a06b00e92
* Correlations: add DeleteCorrelation HTTP API * fix error message copy * add readonly check * add source_uid in delete condition * make path singular * Revert "make path singular" This reverts commit d15be89578e202e5cb64a3e964ee09521b72d87c. * add tests * fix lint errors * fix lint errors * change casing * update spec * Remove transaction * change casing in param name in docs
79 lines
2.9 KiB
Go
79 lines
2.9 KiB
Go
package correlations
|
|
|
|
import (
|
|
"errors"
|
|
"net/http"
|
|
|
|
"github.com/grafana/grafana/pkg/api/response"
|
|
"github.com/grafana/grafana/pkg/api/routing"
|
|
"github.com/grafana/grafana/pkg/middleware"
|
|
"github.com/grafana/grafana/pkg/models"
|
|
ac "github.com/grafana/grafana/pkg/services/accesscontrol"
|
|
"github.com/grafana/grafana/pkg/services/datasources"
|
|
|
|
"github.com/grafana/grafana/pkg/web"
|
|
)
|
|
|
|
func (s *CorrelationsService) registerAPIEndpoints() {
|
|
uidScope := datasources.ScopeProvider.GetResourceScopeUID(ac.Parameter(":uid"))
|
|
authorize := ac.Middleware(s.AccessControl)
|
|
|
|
s.RouteRegister.Group("/api/datasources/uid/:uid/correlations", func(entities routing.RouteRegister) {
|
|
entities.Post("/", middleware.ReqSignedIn, authorize(ac.ReqOrgAdmin, ac.EvalPermission(datasources.ActionWrite, uidScope)), routing.Wrap(s.createHandler))
|
|
entities.Delete("/:correlationUID", middleware.ReqSignedIn, authorize(ac.ReqOrgAdmin, ac.EvalPermission(datasources.ActionWrite, uidScope)), routing.Wrap(s.deleteHandler))
|
|
})
|
|
}
|
|
|
|
// createHandler handles POST /datasources/uid/:uid/correlations
|
|
func (s *CorrelationsService) createHandler(c *models.ReqContext) response.Response {
|
|
cmd := CreateCorrelationCommand{}
|
|
if err := web.Bind(c.Req, &cmd); err != nil {
|
|
return response.Error(http.StatusBadRequest, "bad request data", err)
|
|
}
|
|
cmd.SourceUID = web.Params(c.Req)[":uid"]
|
|
cmd.OrgId = c.OrgId
|
|
|
|
correlation, err := s.CreateCorrelation(c.Req.Context(), cmd)
|
|
if err != nil {
|
|
if errors.Is(err, ErrSourceDataSourceDoesNotExists) || errors.Is(err, ErrTargetDataSourceDoesNotExists) {
|
|
return response.Error(http.StatusNotFound, "Data source not found", err)
|
|
}
|
|
|
|
if errors.Is(err, ErrSourceDataSourceReadOnly) {
|
|
return response.Error(http.StatusForbidden, "Data source is read only", err)
|
|
}
|
|
|
|
return response.Error(http.StatusInternalServerError, "Failed to add correlation", err)
|
|
}
|
|
|
|
return response.JSON(http.StatusOK, CreateCorrelationResponse{Result: correlation, Message: "Correlation created"})
|
|
}
|
|
|
|
// deleteHandler handles DELETE /datasources/uid/:uid/correlations/:correlationUID
|
|
func (s *CorrelationsService) deleteHandler(c *models.ReqContext) response.Response {
|
|
cmd := DeleteCorrelationCommand{
|
|
UID: web.Params(c.Req)[":correlationUID"],
|
|
SourceUID: web.Params(c.Req)[":uid"],
|
|
OrgId: c.OrgId,
|
|
}
|
|
|
|
err := s.DeleteCorrelation(c.Req.Context(), cmd)
|
|
if err != nil {
|
|
if errors.Is(err, ErrSourceDataSourceDoesNotExists) {
|
|
return response.Error(http.StatusNotFound, "Data source not found", err)
|
|
}
|
|
|
|
if errors.Is(err, ErrCorrelationNotFound) {
|
|
return response.Error(http.StatusNotFound, "Correlation not found", err)
|
|
}
|
|
|
|
if errors.Is(err, ErrSourceDataSourceReadOnly) {
|
|
return response.Error(http.StatusForbidden, "Data source is read only", err)
|
|
}
|
|
|
|
return response.Error(http.StatusInternalServerError, "Failed to delete correlation", err)
|
|
}
|
|
|
|
return response.JSON(http.StatusOK, DeleteCorrelationResponse{Message: "Correlation deleted"})
|
|
}
|