mirror of
https://github.com/grafana/grafana.git
synced 2025-07-31 07:02:12 +08:00

* chore(plugins): bump systemjs to latest version * refactor(plugins): switch runtime over to use latest systemjs, add typings * refactor(plugins): use latest systemjs APIs for runtime dependency resolution * refactor(plugins): return valid urls from backend for latest systemjs import to work * revert(plugins): remove cfg from assetpath in favour of relative paths * fix(plugins): useDefault for systemjs deps to solve undefined errors * feat(plugins): add basic support for loading plugins via CDN * fix(plugins): load nested plugins with latest systemjs * feat(plugins): add back ability to transform plugin src for cdns * feat(plugins): get caching for module.js working, clean up * refactor(plugin_loader): create buildImportMap fn and more clean up * refactor(angularapp): use buildImportMap for dependencies and clean up * test(plugin_loader): fix failing test due to systemjs update * test(jest): mock systemjs amd extra in tests to prevent it breaking tests * chore(plugins): remove systemjs module-types extra, already included with system * fix(plugins): update key for invalidating cached plugins * fix: move systemjs amd define to another global so monaco can load * refactor(plugins): clean up cache buster and tests * chore(plugins): remove debug * refactor(plugins): move systemjs define to keep global cleaner * fix(plugins): set useDefault so system modules lodash references dont fail * feat(plugins): hook systemjs onload so stylesheets are applied to the dom * refactor(plugins): wrap amd formatted plugins in iife to prevent define collision * feat(plugins): support system module format for legacy plugins * test(plugincachebuster): update tests to match latest implementation * test(plugins-loader): fix up tests post module property change * fix test * Update pkg/plugins/manager/loader/assetpath/assetpath.go Co-authored-by: Will Browne <wbrowne@users.noreply.github.com> * chore(plugin_loader): remove stray import from merge conflict * Revert "Update pkg/plugins/manager/loader/assetpath/assetpath.go" This reverts commit 0df57d1cf20f49c22c93369001c70aae46a97c42. * fix(plugin_loader): set use default for shared plugin dependencies * refactor(plugins): use leading slash for Module and BaseUrl * fix(plugins): fix resolve appending extension to cache query param * refactor(plugins): align baseurl and module paths * refactor(plugins): update builtInPlugins keys to match naming convention * refactor(plugins): minor loader clean up, fix up types * test(plugins): fix failing tests * refactor(plugins): rename cache buster systemjs plugin to cache * refactor(plugins): separate plugin_loader into smaller files * chore(plugins): clean up plugin_loader types * chore(plugin_sandbox): fix typescript error * chore(npm): remove unplug debug and pin systemjs to 6.14.1 * refactor(plugins-cdn): update loaders to use absolute module url from backend * fix(plugins): escape period in systemjs module regex * chore(plugins): delete redundant systemjs plugins * refactor(plugin_loader): move hooks into own file, add types * test(plugins): add tests for systemjs loader hooks * chore(plugins): rename systemjshooks file * chore(plugins): remove redundant systemjs cdn backend code * fix(plugins): handle loading with config.appSubUrl * chore(plugins): delete redundant plugin-cdn angular code * test(plugins): fix failing systemjs test missing pluginsCDNBaseUrl * refactor(plugins): backend provides base and module properties with AppSubUrl * fix(plugins): consider AppSubUrl for plugin logos * fix(plugins): use isHostedOnCDN util when checking for cdn hosted plugins * add new appSubURL field to config * refactor relative URL func * fix path for core app * refactor asset path input * fix(plugins): catch errors in loadPluginCss * feat(plugins-cdn): selectively transform sourceMapURL * re-add deleted test case * chore(plugins): bump to latest systemjs@6.14.2 * feat(plugins): add systemjs-cjs-extra for loading commonjs plugins --------- Co-authored-by: Will Browne <will.browne@grafana.com> Co-authored-by: Will Browne <wbrowne@users.noreply.github.com>
120 lines
4.0 KiB
Go
120 lines
4.0 KiB
Go
package bootstrap
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/grafana/grafana/pkg/plugins"
|
|
"github.com/grafana/grafana/pkg/plugins/config"
|
|
"github.com/grafana/grafana/pkg/plugins/log"
|
|
"github.com/grafana/grafana/pkg/plugins/manager/fakes"
|
|
)
|
|
|
|
func TestSetDefaultNavURL(t *testing.T) {
|
|
t.Run("When including a dashboard with DefaultNav: true", func(t *testing.T) {
|
|
pluginWithDashboard := &plugins.Plugin{
|
|
JSONData: plugins.JSONData{Includes: []*plugins.Includes{
|
|
{
|
|
Type: "dashboard",
|
|
DefaultNav: true,
|
|
UID: "",
|
|
},
|
|
}},
|
|
}
|
|
logger := log.NewTestLogger()
|
|
pluginWithDashboard.SetLogger(logger)
|
|
|
|
t.Run("Default nav URL is not set if dashboard UID field not is set", func(t *testing.T) {
|
|
setDefaultNavURL(pluginWithDashboard)
|
|
require.Equal(t, "", pluginWithDashboard.DefaultNavURL)
|
|
require.NotZero(t, logger.WarnLogs.Calls)
|
|
require.Equal(t, "Included dashboard is missing a UID field", logger.WarnLogs.Message)
|
|
})
|
|
|
|
t.Run("Default nav URL is set if dashboard UID field is set", func(t *testing.T) {
|
|
pluginWithDashboard.Includes[0].UID = "a1b2c3"
|
|
|
|
setDefaultNavURL(pluginWithDashboard)
|
|
require.Equal(t, "/d/a1b2c3", pluginWithDashboard.DefaultNavURL)
|
|
})
|
|
})
|
|
|
|
t.Run("When including a page with DefaultNav: true", func(t *testing.T) {
|
|
pluginWithPage := &plugins.Plugin{
|
|
JSONData: plugins.JSONData{Includes: []*plugins.Includes{
|
|
{
|
|
Type: "page",
|
|
DefaultNav: true,
|
|
Slug: "testPage",
|
|
},
|
|
}},
|
|
}
|
|
|
|
t.Run("Default nav URL is set using slug", func(t *testing.T) {
|
|
setDefaultNavURL(pluginWithPage)
|
|
require.Equal(t, "/plugins/page/testPage", pluginWithPage.DefaultNavURL)
|
|
})
|
|
|
|
t.Run("Default nav URL is set using slugified Name field if Slug field is empty", func(t *testing.T) {
|
|
pluginWithPage.Includes[0].Slug = ""
|
|
pluginWithPage.Includes[0].Name = "My Test Page"
|
|
|
|
setDefaultNavURL(pluginWithPage)
|
|
require.Equal(t, "/plugins/page/my-test-page", pluginWithPage.DefaultNavURL)
|
|
})
|
|
})
|
|
}
|
|
|
|
func Test_configureAppChildPlugin(t *testing.T) {
|
|
t.Run("When setting paths based on core plugin on Windows", func(t *testing.T) {
|
|
child := &plugins.Plugin{
|
|
FS: fakes.NewFakePluginFiles("c:\\grafana\\public\\app\\plugins\\app\\testdata-app\\datasources\\datasource"),
|
|
}
|
|
parent := &plugins.Plugin{
|
|
JSONData: plugins.JSONData{
|
|
Type: plugins.TypeApp,
|
|
ID: "testdata-app",
|
|
},
|
|
Class: plugins.ClassCore,
|
|
FS: fakes.NewFakePluginFiles("c:\\grafana\\public\\app\\plugins\\app\\testdata-app"),
|
|
BaseURL: "/public/app/plugins/app/testdata-app",
|
|
}
|
|
|
|
configureAppChildPlugin(&config.Cfg{}, parent, child)
|
|
|
|
require.Equal(t, "core:plugin/testdata-app/datasources/datasource", child.Module)
|
|
require.Equal(t, "testdata-app", child.IncludedInAppID)
|
|
require.Equal(t, "/public/app/plugins/app/testdata-app", child.BaseURL)
|
|
|
|
t.Run("App sub URL has no effect on Core plugins", func(t *testing.T) {
|
|
configureAppChildPlugin(&config.Cfg{GrafanaAppSubURL: "/grafana"}, parent, child)
|
|
|
|
require.Equal(t, "core:plugin/testdata-app/datasources/datasource", child.Module)
|
|
require.Equal(t, "testdata-app", child.IncludedInAppID)
|
|
require.Equal(t, "/public/app/plugins/app/testdata-app", child.BaseURL)
|
|
})
|
|
})
|
|
|
|
t.Run("When setting paths based on external plugin with app sub URL", func(t *testing.T) {
|
|
child := &plugins.Plugin{
|
|
FS: fakes.NewFakePluginFiles("/plugins/parent-app/child-panel"),
|
|
}
|
|
parent := &plugins.Plugin{
|
|
JSONData: plugins.JSONData{
|
|
Type: plugins.TypeApp,
|
|
ID: "testdata-app",
|
|
},
|
|
Class: plugins.ClassExternal,
|
|
FS: fakes.NewFakePluginFiles("/plugins/parent-app"),
|
|
BaseURL: "/grafana/plugins/parent-app",
|
|
}
|
|
|
|
configureAppChildPlugin(&config.Cfg{GrafanaAppSubURL: "/grafana"}, parent, child)
|
|
|
|
require.Equal(t, "/grafana/public/plugins/testdata-app/child-panel/module.js", child.Module)
|
|
require.Equal(t, "testdata-app", child.IncludedInAppID)
|
|
require.Equal(t, "/grafana/plugins/parent-app", child.BaseURL)
|
|
})
|
|
}
|