mirror of
https://github.com/grafana/grafana.git
synced 2025-07-29 05:12:31 +08:00
a18ea34688
* CloudWatch: Backport aws-sdk-go-v2 update from external plugin * Review feedback & cleaning up a couple typos
59 lines
2.8 KiB
Go
59 lines
2.8 KiB
Go
package cloudwatch
|
|
|
|
import (
|
|
"fmt"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
|
|
"github.com/grafana/grafana/pkg/tsdb/cloudwatch/models/resources"
|
|
"github.com/grafana/grafana/pkg/tsdb/cloudwatch/services"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/mock"
|
|
|
|
"github.com/grafana/grafana/pkg/tsdb/cloudwatch/mocks"
|
|
"github.com/grafana/grafana/pkg/tsdb/cloudwatch/models"
|
|
)
|
|
|
|
func Test_DimensionValues_Route(t *testing.T) {
|
|
origNewListMetricsService := services.NewListMetricsService
|
|
t.Cleanup(func() {
|
|
services.NewListMetricsService = origNewListMetricsService
|
|
})
|
|
|
|
var mockListMetricsService mocks.ListMetricsServiceMock
|
|
services.NewListMetricsService = func(models.MetricsClientProvider) models.ListMetricsProvider {
|
|
return &mockListMetricsService
|
|
}
|
|
|
|
t.Run("Calls GetDimensionValuesByDimensionFilter when a valid request is passed", func(t *testing.T) {
|
|
mockListMetricsService = mocks.ListMetricsServiceMock{}
|
|
mockListMetricsService.On("GetDimensionValuesByDimensionFilter", mock.MatchedBy(func(r resources.DimensionValuesRequest) bool {
|
|
return r.ResourceRequest != nil && *r.ResourceRequest == resources.ResourceRequest{Region: "us-east-2"} &&
|
|
r.Namespace == "AWS/EC2" &&
|
|
r.MetricName == "CPUUtilization" &&
|
|
r.DimensionKey == "instanceId" &&
|
|
len(r.DimensionFilter) == 2 &&
|
|
assert.Contains(t, r.DimensionFilter, &resources.Dimension{Name: "NodeID", Value: "Shared"}) &&
|
|
assert.Contains(t, r.DimensionFilter, &resources.Dimension{Name: "stage", Value: "QueryCommit"})
|
|
})).Return([]resources.ResourceResponse[string]{}, nil).Once()
|
|
rr := httptest.NewRecorder()
|
|
req := httptest.NewRequest("GET", `/dimension-values?region=us-east-2&dimensionKey=instanceId&namespace=AWS/EC2&metricName=CPUUtilization&dimensionFilters={"NodeID":["Shared"],"stage":["QueryCommit"]}`, nil)
|
|
ds := newTestDatasource()
|
|
handler := http.HandlerFunc(ds.resourceRequestMiddleware(ds.DimensionValuesHandler))
|
|
handler.ServeHTTP(rr, req)
|
|
})
|
|
|
|
t.Run("returns 500 if GetDimensionValuesByDimensionFilter returns an error", func(t *testing.T) {
|
|
mockListMetricsService = mocks.ListMetricsServiceMock{}
|
|
mockListMetricsService.On("GetDimensionValuesByDimensionFilter", mock.Anything).Return([]resources.ResourceResponse[string]{}, fmt.Errorf("some error"))
|
|
rr := httptest.NewRecorder()
|
|
req := httptest.NewRequest("GET", `/dimension-values?region=us-east-2&dimensionKey=instanceId&namespace=AWS/EC2&metricName=CPUUtilization&dimensionFilters={"NodeID":["Shared"],"stage":["QueryCommit"]}`, nil)
|
|
ds := newTestDatasource()
|
|
handler := http.HandlerFunc(ds.resourceRequestMiddleware(ds.DimensionValuesHandler))
|
|
handler.ServeHTTP(rr, req)
|
|
assert.Equal(t, http.StatusInternalServerError, rr.Code)
|
|
assert.Equal(t, `{"Message":"error in DimensionValuesHandler: some error","Error":"some error","StatusCode":500}`, rr.Body.String())
|
|
})
|
|
}
|