grafana/pkg/services/sqlstore/alert_rule_test.go

package sqlstore

import (
	"testing"

	m "github.com/grafana/grafana/pkg/models"
	. "github.com/smartystreets/goconvey/convey"
)

func TestAlertingDataAccess(t *testing.T) {

	Convey("Testing Alerting data access", t, func() {
		InitTestDB(t)

		testDash := insertTestDashboard("dashboard with alerts", 1, "alert")

		items := []*m.AlertRule{
			&m.AlertRule{
				PanelId:      1,
				DashboardId:  testDash.Id,
				OrgId:        testDash.OrgId,
				Query:        "Query",
				QueryRefId:   "A",
				WarnLevel:    30,
				CritLevel:    50,
				WarnOperator: ">",
				CritOperator: ">",
				Frequency:    10,
				Name:         "Alerting title",
				Description:  "Alerting description",
				QueryRange:   3600,
				Aggregator:   "avg",
				DatasourceId: 42,
			},
		}

		cmd := m.SaveAlertsCommand{
			Alerts:      items,
			DashboardId: testDash.Id,
			OrgId:       1,
			UserId:      1,
		}

		err := SaveAlerts(&cmd)

		Convey("Can create one alert", func() {
			So(err, ShouldBeNil)

			query := &m.GetAlertChangesQuery{OrgId: 1}
			er := GetAlertRuleChanges(query)
			So(er, ShouldBeNil)
			So(len(query.Result), ShouldEqual, 1)
		})

		Convey("Can read properties", func() {
			alertQuery := m.GetAlertsQuery{DashboardId: testDash.Id, PanelId: 1, OrgId: 1}
			err2 := HandleAlertsQuery(&alertQuery)

			alert := alertQuery.Result[0]
			So(err2, ShouldBeNil)
			So(alert.Frequency, ShouldEqual, 10)
			So(alert.WarnLevel, ShouldEqual, 30)
			So(alert.CritLevel, ShouldEqual, 50)
			So(alert.WarnOperator, ShouldEqual, ">")
			So(alert.CritOperator, ShouldEqual, ">")
			So(alert.Query, ShouldEqual, "Query")
			So(alert.QueryRefId, ShouldEqual, "A")
			So(alert.Name, ShouldEqual, "Alerting title")
			So(alert.Description, ShouldEqual, "Alerting description")
			So(alert.QueryRange, ShouldEqual, 3600)
			So(alert.Aggregator, ShouldEqual, "avg")
			So(alert.State, ShouldEqual, "OK")
			So(alert.DatasourceId, ShouldEqual, 42)
		})

		Convey("Alerts with same dashboard id and panel id should update", func() {
			modifiedItems := items
			modifiedItems[0].Query = "Updated Query"
			modifiedItems[0].State = "ALERT"

			modifiedCmd := m.SaveAlertsCommand{
				DashboardId: testDash.Id,
				OrgId:       1,
				UserId:      1,
				Alerts:      modifiedItems,
			}

			err := SaveAlerts(&modifiedCmd)

			Convey("Can save alerts with same dashboard and panel id", func() {
				So(err, ShouldBeNil)
			})

			Convey("Alerts should be updated", func() {
				query := m.GetAlertsQuery{DashboardId: testDash.Id, OrgId: 1}
				err2 := HandleAlertsQuery(&query)

				So(err2, ShouldBeNil)
				So(len(query.Result), ShouldEqual, 1)
				So(query.Result[0].Query, ShouldEqual, "Updated Query")

				Convey("Alert state should not be updated", func() {
					So(query.Result[0].State, ShouldEqual, "OK")
				})
			})

			Convey("Updates without changes should be ignored", func() {
				err3 := SaveAlerts(&modifiedCmd)
				So(err3, ShouldBeNil)

				query := &m.GetAlertChangesQuery{OrgId: 1}
				er := GetAlertRuleChanges(query)
				So(er, ShouldBeNil)
				So(len(query.Result), ShouldEqual, 2)
			})
		})

		Convey("Multiple alerts per dashboard", func() {
			multipleItems := []*m.AlertRule{
				&m.AlertRule{
					DashboardId: testDash.Id,
					PanelId:     1,
					Query:       "1",
					OrgId:       1,
				},
				&m.AlertRule{
					DashboardId: testDash.Id,
					PanelId:     2,
					Query:       "2",
					OrgId:       1,
				},
				&m.AlertRule{
					DashboardId: testDash.Id,
					PanelId:     3,
					Query:       "3",
					OrgId:       1,
				},
			}

			cmd.Alerts = multipleItems
			err = SaveAlerts(&cmd)

			Convey("Should save 3 dashboards", func() {
				So(err, ShouldBeNil)

				queryForDashboard := m.GetAlertsQuery{DashboardId: testDash.Id, OrgId: 1}
				err2 := HandleAlertsQuery(&queryForDashboard)

				So(err2, ShouldBeNil)
				So(len(queryForDashboard.Result), ShouldEqual, 3)

				query := &m.GetAlertChangesQuery{OrgId: 1}
				er := GetAlertRuleChanges(query)
				So(er, ShouldBeNil)
				So(len(query.Result), ShouldEqual, 4)
			})

			Convey("should updated two dashboards and delete one", func() {
				missingOneAlert := multipleItems[:2]

				cmd.Alerts = missingOneAlert
				err = SaveAlerts(&cmd)

				Convey("should delete the missing alert", func() {
					query := m.GetAlertsQuery{DashboardId: testDash.Id, OrgId: 1}
					err2 := HandleAlertsQuery(&query)
					So(err2, ShouldBeNil)
					So(len(query.Result), ShouldEqual, 2)
				})

				Convey("should add one more alert_rule_change", func() {
					query := &m.GetAlertChangesQuery{OrgId: 1}
					er := GetAlertRuleChanges(query)
					So(er, ShouldBeNil)
					So(len(query.Result), ShouldEqual, 6)
				})
			})
		})

		Convey("When dashboard is removed", func() {
			items := []*m.AlertRule{
				&m.AlertRule{
					PanelId:      1,
					DashboardId:  testDash.Id,
					Query:        "Query",
					QueryRefId:   "A",
					WarnLevel:    30,
					CritLevel:    50,
					WarnOperator: ">",
					CritOperator: ">",
					Frequency:    10,
					Name:         "Alerting title",
					Description:  "Alerting description",
					QueryRange:   3600,
					Aggregator:   "avg",
				},
			}

			cmd := m.SaveAlertsCommand{
				Alerts:      items,
				DashboardId: testDash.Id,
				OrgId:       1,
				UserId:      1,
			}

			SaveAlerts(&cmd)

			err = DeleteDashboard(&m.DeleteDashboardCommand{
				OrgId: 1,
				Slug:  testDash.Slug,
			})

			So(err, ShouldBeNil)

			Convey("Alerts should be removed", func() {
				query := m.GetAlertsQuery{DashboardId: testDash.Id, OrgId: 1}
				err2 := HandleAlertsQuery(&query)

				So(testDash.Id, ShouldEqual, 1)
				So(err2, ShouldBeNil)
				So(len(query.Result), ShouldEqual, 0)
			})
		})
	})
}