mirror of
https://github.com/grafana/grafana.git
synced 2025-07-31 15:22:26 +08:00

* Picking role registration from OnCall POC branch * Fix test * Remove include actions from this PR * Removing unused permission * Adding test to DeclarePluginRoles * Add testcase to RegisterFixed role * Additional test case * Adding tests to validate plugins roles * Add test to plugin loader * Nit. * Scuemata validation * Changing the design to decouple accesscontrol from plugin management Co-authored-by: Kalle Persson <kalle.persson@grafana.com> * Fixing tests Co-authored-by: Jguer <joao.guerreiro@grafana.com> * Add missing files Co-authored-by: Jguer <joao.guerreiro@grafana.com> * Remove feature toggle check from loader * Remove feature toggleimport * Feedback Co-Authored-By: marefr <marcus.efraimsson@gmail.com> * Fix test' * Make plugins.RoleRegistry interface typed * Remove comment question * No need for json tags anymore * Nit. log * Adding the schema validation * Remove group to take plugin Name instead * Revert sqlstore -> db * Nit. * Nit. on tests Co-authored-by: ievaVasiljeva <ieva.vasiljeva@grafana.com> * Update pkg/services/accesscontrol/plugins.go Co-authored-by: Ieva <ieva.vasiljeva@grafana.com> * Log message Co-Authored-By: marefr <marcus.efraimsson@gmail.com> * Log message Co-Authored-By: marefr <marcus.efraimsson@gmail.com> * Remove unecessary method. Update test name. Co-authored-by: ievaVasiljeva <ieva.vasiljeva@grafana.com> * Fix linting * Update cue descriptions * Fix test Co-authored-by: Kalle Persson <kalle.persson@grafana.com> Co-authored-by: Jguer <joao.guerreiro@grafana.com> Co-authored-by: marefr <marcus.efraimsson@gmail.com> Co-authored-by: ievaVasiljeva <ieva.vasiljeva@grafana.com>
63 lines
2.0 KiB
Go
63 lines
2.0 KiB
Go
package pluginutils
|
|
|
|
import (
|
|
"strings"
|
|
|
|
"github.com/grafana/grafana/pkg/plugins"
|
|
ac "github.com/grafana/grafana/pkg/services/accesscontrol"
|
|
)
|
|
|
|
// ValidatePluginPermissions errors when a permission does not match expected pattern for plugins
|
|
func ValidatePluginPermissions(pluginID string, permissions []ac.Permission) error {
|
|
for i := range permissions {
|
|
if permissions[i].Action != plugins.ActionAppAccess &&
|
|
!strings.HasPrefix(permissions[i].Action, pluginID+":") &&
|
|
!strings.HasPrefix(permissions[i].Action, pluginID+".") {
|
|
return &ac.ErrorActionPrefixMissing{Action: permissions[i].Action,
|
|
Prefixes: []string{plugins.ActionAppAccess, pluginID + ":", pluginID + "."}}
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// ValidatePluginRole errors when a plugin role does not match expected pattern
|
|
// or doesn't have permissions matching the expected pattern.
|
|
func ValidatePluginRole(pluginID string, role ac.RoleDTO) error {
|
|
if pluginID == "" {
|
|
return ac.ErrPluginIDRequired
|
|
}
|
|
if !strings.HasPrefix(role.Name, ac.PluginRolePrefix+pluginID+":") {
|
|
return &ac.ErrorRolePrefixMissing{Role: role.Name, Prefixes: []string{ac.PluginRolePrefix + pluginID + ":"}}
|
|
}
|
|
|
|
return ValidatePluginPermissions(pluginID, role.Permissions)
|
|
}
|
|
|
|
func ToRegistrations(pluginName string, regs []plugins.RoleRegistration) []ac.RoleRegistration {
|
|
res := make([]ac.RoleRegistration, 0, len(regs))
|
|
for i := range regs {
|
|
res = append(res, ac.RoleRegistration{
|
|
Role: ac.RoleDTO{
|
|
Version: 1,
|
|
Name: regs[i].Role.Name,
|
|
DisplayName: regs[i].Role.DisplayName,
|
|
Description: regs[i].Role.Description,
|
|
Group: pluginName,
|
|
Permissions: toPermissions(regs[i].Role.Permissions),
|
|
OrgID: ac.GlobalOrgID,
|
|
},
|
|
Grants: regs[i].Grants,
|
|
})
|
|
}
|
|
return res
|
|
}
|
|
|
|
func toPermissions(perms []plugins.Permission) []ac.Permission {
|
|
res := make([]ac.Permission, 0, len(perms))
|
|
for i := range perms {
|
|
res = append(res, ac.Permission{Action: perms[i].Action, Scope: perms[i].Scope})
|
|
}
|
|
return res
|
|
}
|