mirror of
https://github.com/grafana/grafana.git
synced 2025-09-24 08:14:00 +08:00
30aa24a183
* Separate Tracer interface to TracerService and Tracer * Fix lint * Fix:Make it possible to start spans for both opentracing and opentelemetry in ds proxy * Add span methods, use span interface for rest of tracing * Fix logs in tracing * Fix tests that are related to tracing * Fix resourcepermissions test * Fix some tests * Fix more tests * Add TracingService to wire cli runner * Remove GlobalTracer from bus * Renaming test function * Remove GlobalTracer from TSDB * Replace GlobalTracer in api * Adjust tests to the InitializeForTests func * Remove GlobalTracer from services * Remove GlobalTracer * Remove bus.NewTest * Remove Tracer interface * Add InitializeForBus * Simplify tests * Clean up tests * Rename TracerService to Tracer * Update pkg/middleware/request_tracing.go Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com> * Initialize tracer before passing it to SQLStore initialization in commands * Remove tests for opentracing * Set span attributes correctly, remove unnecessary trace initiliazation form test * Add tracer instance to newSQLStore * Fix changes due to rebase * Add modified tracing middleware test * Fix opentracing implementation tags Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>
112 lines
3.4 KiB
Go
112 lines
3.4 KiB
Go
package httpclientprovider
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"net/http"
|
|
"testing"
|
|
|
|
"github.com/grafana/grafana-plugin-sdk-go/backend/httpclient"
|
|
"github.com/grafana/grafana/pkg/infra/log"
|
|
"github.com/grafana/grafana/pkg/infra/tracing"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestTracingMiddleware(t *testing.T) {
|
|
tracer, err := tracing.InitializeTracerForTest()
|
|
require.NoError(t, err)
|
|
|
|
t.Run("GET request that returns 200 OK should start and capture span", func(t *testing.T) {
|
|
finalRoundTripper := httpclient.RoundTripperFunc(func(req *http.Request) (*http.Response, error) {
|
|
return &http.Response{StatusCode: http.StatusOK, Request: req}, nil
|
|
})
|
|
|
|
mw := TracingMiddleware(log.New("test"), tracer)
|
|
rt := mw.CreateMiddleware(httpclient.Options{
|
|
Labels: map[string]string{
|
|
"l1": "v1",
|
|
"l2": "v2",
|
|
},
|
|
}, finalRoundTripper)
|
|
require.NotNil(t, rt)
|
|
middlewareName, ok := mw.(httpclient.MiddlewareName)
|
|
require.True(t, ok)
|
|
require.Equal(t, TracingMiddlewareName, middlewareName.MiddlewareName())
|
|
|
|
ctx := context.Background()
|
|
req, err := http.NewRequestWithContext(ctx, http.MethodGet, "http://test.com/query", nil)
|
|
require.NoError(t, err)
|
|
res, err := rt.RoundTrip(req)
|
|
require.NoError(t, err)
|
|
require.NotNil(t, res)
|
|
if res.Body != nil {
|
|
require.NoError(t, res.Body.Close())
|
|
}
|
|
|
|
_, sp := tracer.Start(ctx, "test")
|
|
require.NotNil(t, sp)
|
|
})
|
|
|
|
t.Run("GET request that returns 400 Bad Request should start and capture span", func(t *testing.T) {
|
|
finalRoundTripper := httpclient.RoundTripperFunc(func(req *http.Request) (*http.Response, error) {
|
|
return &http.Response{StatusCode: http.StatusBadRequest, Request: req}, nil
|
|
})
|
|
|
|
mw := TracingMiddleware(log.New("test"), tracer)
|
|
rt := mw.CreateMiddleware(httpclient.Options{
|
|
Labels: map[string]string{
|
|
"l1": "v1",
|
|
"l2": "v2",
|
|
},
|
|
}, finalRoundTripper)
|
|
require.NotNil(t, rt)
|
|
middlewareName, ok := mw.(httpclient.MiddlewareName)
|
|
require.True(t, ok)
|
|
require.Equal(t, TracingMiddlewareName, middlewareName.MiddlewareName())
|
|
|
|
ctx := context.Background()
|
|
req, err := http.NewRequestWithContext(ctx, http.MethodGet, "http://test.com/query", nil)
|
|
require.NoError(t, err)
|
|
res, err := rt.RoundTrip(req)
|
|
require.NoError(t, err)
|
|
require.NotNil(t, res)
|
|
if res.Body != nil {
|
|
require.NoError(t, res.Body.Close())
|
|
}
|
|
|
|
_, sp := tracer.Start(res.Request.Context(), "test")
|
|
require.NotNil(t, sp)
|
|
})
|
|
|
|
t.Run("POST request that returns 200 OK should start and capture span", func(t *testing.T) {
|
|
finalRoundTripper := httpclient.RoundTripperFunc(func(req *http.Request) (*http.Response, error) {
|
|
return &http.Response{StatusCode: http.StatusOK, Request: req, ContentLength: 10}, nil
|
|
})
|
|
|
|
mw := TracingMiddleware(log.New("test"), tracer)
|
|
rt := mw.CreateMiddleware(httpclient.Options{
|
|
Labels: map[string]string{
|
|
"l1": "v1",
|
|
"l2": "v2",
|
|
},
|
|
}, finalRoundTripper)
|
|
require.NotNil(t, rt)
|
|
middlewareName, ok := mw.(httpclient.MiddlewareName)
|
|
require.True(t, ok)
|
|
require.Equal(t, TracingMiddlewareName, middlewareName.MiddlewareName())
|
|
|
|
ctx := context.Background()
|
|
req, err := http.NewRequestWithContext(ctx, http.MethodPost, "http://test.com/query", bytes.NewBufferString("{ \"message\": \"ok\"}"))
|
|
require.NoError(t, err)
|
|
res, err := rt.RoundTrip(req)
|
|
require.NoError(t, err)
|
|
require.NotNil(t, res)
|
|
if res.Body != nil {
|
|
require.NoError(t, res.Body.Close())
|
|
}
|
|
|
|
_, sp := tracer.Start(res.Request.Context(), "test")
|
|
require.NotNil(t, sp)
|
|
})
|
|
}
|