mirror of
https://github.com/grafana/grafana.git
synced 2025-07-30 12:42:17 +08:00
5c03c14b25
* resource-api: Loosen name validation to match K8s requirements This patch modifies some of the requirements for name validation of objects in Resource API to match Kubernetes. The limit we have on characters in name is 64, but some resources allow upto 253 characters. Similarly we also include `:` in the regex, as many objects in default K8s setup use it in the name (the group `system:masters` for example) Signed-off-by: Prem Kumar <prem.saraswat@grafana.com> * Update the name column length in migrator and update e2e test to verify --------- Signed-off-by: Prem Kumar <prem.saraswat@grafana.com>
31 lines
879 B
Go
31 lines
879 B
Go
package resource
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestNameValidation(t *testing.T) {
|
|
require.NotNil(t, validateName("")) // too short
|
|
require.NotNil(t, validateName(strings.Repeat("0", 254))) // too long (max 253)
|
|
|
|
// OK
|
|
require.Nil(t, validateName("a"))
|
|
require.Nil(t, validateName("hello-world"))
|
|
require.Nil(t, validateName("hello.world"))
|
|
require.Nil(t, validateName("hello_world"))
|
|
require.Nil(t, validateName("hello:world"))
|
|
|
|
// Bad characters
|
|
require.NotNil(t, validateName("hello world"))
|
|
require.NotNil(t, validateName("hello!"))
|
|
require.NotNil(t, validateName("hello~"))
|
|
require.NotNil(t, validateName("hello "))
|
|
require.NotNil(t, validateName("hello*"))
|
|
require.NotNil(t, validateName("hello+"))
|
|
require.NotNil(t, validateName("hello="))
|
|
require.NotNil(t, validateName("hello%"))
|
|
}
|