4b4d546e32
Typed variables pt4: Remove generics from getVariable ( #53017 )
...
* wip
* make diff easier to read
* Update template_srv getVariables to return new TypedVariableModel
* update VariableType to use the type from TypedVariableModel
* tidy things up
* Chore: Use type-accurate mock variables in tests
* Chore: Type VariableState to use TypedVariableModel
* fix typo
* remove type assertion from template_srv.getVariables
* use typescript/no-redeclare for compatibility with ts overloads
* remove generics from getVariable() and overload it to only return undefined based on arguments
* update usages of getVariable()
* Fix Interval variable options picker not working
2022-08-05 13:44:52 +01:00
683bbc7373
Templating: Changing between variables with the same name now correctly triggers a dashboard refresh ( #51490 )
...
* user essentials mob! 🔱
* user essentials mob! 🔱
lastFile:public/app/features/variables/pickers/OptionsPicker/actions.ts
* user essentials mob! 🔱
lastFile:public/app/features/variables/pickers/OptionsPicker/actions.test.ts
* linting
* update betterer
Co-authored-by: kay delaney <kay@grafana.com>
2022-06-29 09:10:55 +01:00
3c6e0e8ef8
Chore: ESlint import order ( #44959 )
...
* Add and configure eslint-plugin-import
* Fix the lint:ts npm command
* Autofix + prettier all the files
* Manually fix remaining files
* Move jquery code in jest-setup to external file to safely reorder imports
* Resolve issue caused by circular dependencies within Prometheus
* Update .betterer.results
* Fix missing // @ts-ignore
* ignore iconBundle.ts
* Fix missing // @ts-ignore
2022-04-22 14:33:13 +01:00
dbec2b02fd
Variables: move state tree into a keyed state ( #44642 )
...
* Variables: move state tree into a keyed state
* Update public/app/features/variables/state/transactionReducer.ts
Co-authored-by: kay delaney <45561153+kaydelaney@users.noreply.github.com>
* Chore: fix prettier error
* Chore: renamed slices and lastUid
* Chore: rename toUidAction
* Chore: rename dashboardVariableReducer
* Chore: rename state prop back to templating
* Chore renames variable.dashboardUid
* Chore: rename toDashboardVariableIdentifier
* Chore: rename getDashboardVariable
* Chore: rename getDashboardVariablesState
* Chore: rename getDashboardVariables
* Chore: some more renames
* Chore: small clean up
* Chore: small rename
* Chore: removes unused function
* Chore: rename VariableModel.stateKey
* Chore: rename KeyedVariableIdentifier.stateKey
* user essentials mob! 🔱
* user essentials mob! 🔱
* user essentials mob! 🔱
* user essentials mob! 🔱
Co-authored-by: kay delaney <45561153+kaydelaney@users.noreply.github.com>
Co-authored-by: kay delaney <kay@grafana.com>
Co-authored-by: Alexandra Vargas <alexa1866@gmail.com>
Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
2022-02-18 06:06:04 +01:00
d87cd6f26c
Update dependency prettier to v2.5.1 ( #43473 )
...
* Update dependency prettier to v2.5.1
* prettier fixes
* chore(toolkit): bump prettier to 2.5.1
* style(eslint): bump grafana config to 2.5.2 in core and toolkit
* style(mssql-datasource): fix no-inferrable-types eslint errors
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com>
2022-02-02 12:02:32 +00:00
f73be970d3
Variables: Removes experimental Tags feature ( #33361 )
...
* Variables: Removes experimental Tags feature
* Refactor: adds dashboard migration
* Tests: fixes snapshots
* Docs: removes docs for experimental feature
* Refactor: dummy change
* Docs: removes reference
2021-04-27 05:57:25 +02:00
bad048b7ba
Performance: Standardize lodash imports to use destructured members ( #33040 )
...
* Performance: Standardize lodash imports to use destructured members
Changes lodash imports of the form `import x from 'lodash/x'` to
`import { x } from 'lodash'` to reduce bundle size.
* Remove unnecessary _ import from Graph component
* Enforce lodash import style
* Fix remaining lodash imports
2021-04-21 09:38:00 +02:00
6087980de0
Variables: Confirms selection before opening new picker ( #32586 )
...
* Variables: Confirms selection before opening new picker
* Tests: fixes e2e tests
2021-04-06 09:21:37 +02:00
7e0b1f2619
Templating: use dashboard timerange when variables are set to refresh 'On Dashboard Load' ( #31721 )
...
* Templating: use dashboard timerange when variables are set to load 'On Dashboard Load'
* Add test
2021-03-09 09:20:21 +00:00
3c1f27b0e6
Chore: reduce strict errors for variables ( #31241 )
...
* Chore: reduces a lot of variable errors
* Chore: reduces variable Editor errors
* Chore: reduces variable Picker errors
* Chore: reduce error count
* Chore: reduces errors for ChangeEvent instead of FormEvent
* Chore: reduces errors with CombinedState
* Chore: reduces ComponentType errors
* Chore: reduce errors in reducers
* Chore: reduces misc errors
* Chore: reduce AdhocPicker errors
* Chore: reduce error limit
* Update public/app/features/variables/adhoc/picker/AdHocFilterValue.tsx
Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>
* Chore: updates after PR comments
* Chore: small refactor
Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>
2021-02-18 06:21:35 +01:00
6f1a38cbe2
Variables: Extend option pickers to accept custom onChange callback ( #30913 )
...
* Rename DashboardPicker props
* Extend variable option pickers to allow providing custom onchage callback
* Update public/app/features/variables/pickers/OptionsPicker/actions.ts
Co-authored-by: Hugo Häggmark <hugo.haggmark@grafana.com>
* Update public/app/features/variables/pickers/OptionsPicker/actions.ts
Co-authored-by: Hugo Häggmark <hugo.haggmark@grafana.com>
* Update public/app/features/variables/pickers/OptionsPicker/actions.ts
Co-authored-by: Hugo Häggmark <hugo.haggmark@grafana.com>
* Update public/app/features/variables/textbox/TextBoxVariablePicker.tsx
Co-authored-by: Hugo Häggmark <hugo.haggmark@grafana.com>
* Codeformat
Co-authored-by: Hugo Häggmark <hugo.haggmark@grafana.com>
2021-02-12 16:00:12 +02:00
1d689888b0
Prettier: Upgrade to 2 ( #30387 )
...
* Updated package json but not updated source files
* Update eslint plugin
* updated files
2021-01-20 07:59:48 +01:00
0941649566
Templating: Replace all '$tag' in tag values query ( #28343 )
2020-10-17 21:12:05 +02:00
c052abed87
Variables: hides dropdown before refreshing starts ( #28112 )
2020-10-09 06:31:45 +02:00
09a1af3f91
Variables: Fixes issue with All variable not being resolved ( #27151 )
...
* Variables: Fixes issue with All variable not being resolved
* Tests: update tests according to changes
2020-08-24 09:29:21 +02:00
bd75adf515
Templating: Fixes so texts show in picker not the values ( #27002 )
2020-08-17 07:04:27 +02:00
00a9af00fc
Templating: removes old Angular variable system and featureToggle ( #24779 )
...
* Chore: initial commit
* Tests: fixes MetricsQueryEditor.test.tsx
* Tests: fixes cloudwatch/specs/datasource.test.ts
* Tests: fixes stackdriver/specs/datasource.test.ts
* Tests: remove refrences to CustomVariable
* Refactor: moves DefaultVariableQueryEditor
* Refactor: moves utils
* Refactor: moves types
* Refactor: removes variableSrv
* Refactor: removes feature toggle newVariables
* Refactor: removes valueSelectDropDown
* Chore: removes GeneralTabCtrl
* Chore: migrates RowOptions
* Refactor: adds RowOptionsButton
* Refactor: makes the interface more explicit
* Refactor: small changes
* Refactor: changed type as it can be any variable type
* Tests: fixes broken test
* Refactor: changes after PR comments
* Refactor: adds loading state and call to onChange in componentDidMount
2020-06-04 13:44:48 +02:00
13787294c6
Variables: fix so the variable picker will remember selected options between filtering ( #25119 )
...
* added tests to verify flow.
* refactoring picker reducer.
* made all the tests green.
* removed console.log's
* fixed toggle all and making sure the correct values are set on picker open.
* added more tets.
* refactored and added table tests.
* fixed so we select values from selectedValues instead of options.
* fixed so you can navigate and select even after you have filtered a variable.
* adding tests to verify flows when toggling by highlight.
* fixed so enter always selects value before closing.
* improved the code for tags.
2020-06-01 15:06:51 +02:00
05b6d38374
Variables: breaks variable.ts into 2 separate files utils and types ( #22884 )
2020-03-24 05:46:31 +01:00
9af04a49ea
Variables: replaces UUID with name for a more performant lookup in TemplateSrv ( #22858 )
...
* Refactor: renames uuid to id
* Refactor: misc renames
* Refactor: fixes renaming of variable
* Refactor: changes method accessed by templateSrv
* Refactor: fixes for NEW_VARIABLE_ID
* Refactor: rename flow refactor
* Tests: adds missing reducer and action tests
* Refactor: keeping tests consitent
* Chore: reorder imports
* Chore: removes uuid package
* Refactor: fixes imports
2020-03-23 13:45:08 +01:00
1db067396a
Variables: migrates data source variable type to React/Redux ( #22770 )
...
* Refactor: moves all the newVariables part to features/variables directory
* Feature: adds datasource type
* Tests: adds reducer tests
* Tests: covers data source actions with tests
* Chore: reduces strict null errors
2020-03-16 06:32:04 +01:00
