opensource/grafana
1
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-08-06 20:59:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor PostgresQuery

Browse Source
This commit is contained in:
Sven Klemm
2018-07-15 09:36:49 +02:00
parent 844beb660d
commit fa66645b0f
3 changed files with 67 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files

61
public/app/plugins/datasource/postgres/specs/postgres_query.jest.ts
View File

@ -19,8 +19,10 @@ describe('PostgresQuery', function() {
describe('When generating time column SQL', function() {
let query = new PostgresQuery({}, templateSrv);
expect(query.buildTimeColumn({ timeColumn: 'time' })).toBe('time AS "time"');
expect(query.buildTimeColumn({ timeColumn: '"time"' })).toBe('"time" AS "time"');
query.target.timeColumn = 'time';
expect(query.buildTimeColumn()).toBe('time AS "time"');
query.target.timeColumn = '"time"';
expect(query.buildTimeColumn()).toBe('"time" AS "time"');
});
describe('When generating time column SQL with group by time', function() {
@ -28,65 +30,66 @@ describe('PostgresQuery', function() {
{ timeColumn: 'time', groupBy: [{ type: 'time', params: ['5m', 'none'] }] },
templateSrv
);
expect(query.buildTimeColumn(query.target)).toBe('$__timeGroup(time,5m)');
expect(query.buildTimeColumn()).toBe('$__timeGroup(time,5m)');
query = new PostgresQuery({ timeColumn: 'time', groupBy: [{ type: 'time', params: ['5m', 'NULL'] }] }, templateSrv);
expect(query.buildTimeColumn(query.target)).toBe('$__timeGroup(time,5m,NULL)');
expect(query.buildTimeColumn()).toBe('$__timeGroup(time,5m,NULL)');
});
describe('When generating metric column SQL', function() {
let query = new PostgresQuery({}, templateSrv);
expect(query.buildMetricColumn({ metricColumn: 'host' })).toBe('host AS metric');
expect(query.buildMetricColumn({ metricColumn: '"host"' })).toBe('"host" AS metric');
query.target.metricColumn = 'host';
expect(query.buildMetricColumn()).toBe('host AS metric');
query.target.metricColumn = '"host"';
expect(query.buildMetricColumn()).toBe('"host" AS metric');
});
describe('When generating value column SQL', function() {
let query = new PostgresQuery({}, templateSrv);
let column = [{ type: 'column', params: ['value'] }];
expect(query.buildValueColumn(query.target, column)).toBe('value');
expect(query.buildValueColumn(column)).toBe('value');
column = [{ type: 'column', params: ['value'] }, { type: 'alias', params: ['alias'] }];
expect(query.buildValueColumn(query.target, column)).toBe('value AS "alias"');
expect(query.buildValueColumn(column)).toBe('value AS "alias"');
column = [
{ type: 'column', params: ['v'] },
{ type: 'alias', params: ['a'] },
{ type: 'aggregate', params: ['max'] },
];
expect(query.buildValueColumn(query.target, column)).toBe('max(v) AS "a"');
expect(query.buildValueColumn(column)).toBe('max(v) AS "a"');
column = [
{ type: 'column', params: ['v'] },
{ type: 'alias', params: ['a'] },
{ type: 'special', params: ['increase'] },
];
expect(query.buildValueColumn(query.target, column)).toBe('v - lag(v) OVER () AS "a"');
expect(query.buildValueColumn(column)).toBe('v - lag(v) OVER () AS "a"');
});
describe('When generating WHERE clause', function() {
let query = new PostgresQuery({ where: [] }, templateSrv);
let target;
expect(query.buildWhereClause(query.target)).toBe('');
target = { where: [{ type: 'macro', name: '$__timeFilter' }], timeColumn: 't' };
expect(query.buildWhereClause(target)).toBe('\nWHERE\n $__timeFilter(t)');
target = { where: [{ type: 'expression', params: ['v', '=', '1'] }], timeColumn: 't' };
expect(query.buildWhereClause(target)).toBe('\nWHERE\n v = 1');
target = {
where: [{ type: 'macro', name: '$__timeFilter' }, { type: 'expression', params: ['v', '=', '1'] }],
timeColumn: 't',
};
expect(query.buildWhereClause(target)).toBe('\nWHERE\n $__timeFilter(t) AND\n v = 1');
expect(query.buildWhereClause()).toBe('');
query.target.timeColumn = 't';
query.target.where = [{ type: 'macro', name: '$__timeFilter' }];
expect(query.buildWhereClause()).toBe('\nWHERE\n $__timeFilter(t)');
query.target.where = [{ type: 'expression', params: ['v', '=', '1'] }];
expect(query.buildWhereClause()).toBe('\nWHERE\n v = 1');
query.target.where = [{ type: 'macro', name: '$__timeFilter' }, { type: 'expression', params: ['v', '=', '1'] }];
expect(query.buildWhereClause()).toBe('\nWHERE\n $__timeFilter(t) AND\n v = 1');
});
describe('When generating GROUP BY clause', function() {
let query = new PostgresQuery({ groupBy: [] }, templateSrv);
let target;
let query = new PostgresQuery({ groupBy: [], metricColumn: 'none' }, templateSrv);
expect(query.buildGroupByClause(query.target)).toBe('');
target = { groupBy: [{ type: 'time', params: ['5m'] }], metricColumn: 'None' };
expect(query.buildGroupByClause(target)).toBe('\nGROUP BY 1');
target = { groupBy: [{ type: 'time', params: ['5m'] }], metricColumn: 'm' };
expect(query.buildGroupByClause(target)).toBe('\nGROUP BY 1,2');
expect(query.buildGroupByClause()).toBe('');
query.target.groupBy = [{ type: 'time', params: ['5m'] }];
expect(query.buildGroupByClause()).toBe('\nGROUP BY 1');
query.target.metricColumn = 'm';
expect(query.buildGroupByClause()).toBe('\nGROUP BY 1,2');
});
describe('When generating complete statement', function() {
@ -99,6 +102,6 @@ describe('PostgresQuery', function() {
let result = 'SELECT\n t AS "time",\n value\nFROM public.table\nORDER BY 1';
let query = new PostgresQuery(target, templateSrv);
expect(query.buildQuery(query.target)).toBe(result);
expect(query.buildQuery()).toBe(result);
});
});