opensource/grafana
1
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-09-22 17:02:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

Chore: Rewrite some tests to use testify (#28420)

Browse Source 
* Chore: Improve tests to use testify

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
This commit is contained in:
Arve Knudsen
2020-10-21 10:09:42 +02:00
committed by GitHub
parent 97526fc492
commit ec40e49dcb
3 changed files with 29 additions and 69 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
pkg/tsdb/sqleng/sql_engine_test.go
View File

@ -307,27 +307,17 @@ func TestSqlEngine(t *testing.T) {
for _, f := range fixtures {
value, _ := ConvertSqlValueColumnToFloat("col", f)
if !value.Valid {
t.Fatalf("Failed to convert %T value, expected a valid float value", f)
}
if value.Float64 != null.FloatFrom(1).Float64 {
t.Fatalf("Failed to convert %T value, expected a float value of 1.000, but got %v", f, value)
}
So(value.Valid, ShouldBeTrue)
So(value.Float64, ShouldEqual, null.FloatFrom(1).Float64)
}
})
Convey("When converting nil pointer values to float should return expected value", func() {
for _, f := range nilPointerFixtures {
value, err := ConvertSqlValueColumnToFloat("col", f)
So(err, ShouldBeNil)
if err != nil {
t.Fatalf("Failed to convert %T value, expected a non nil error, but got %v", f, err)
}
if value.Valid {
t.Fatalf("Failed to convert %T value, expected an invalid float value", f)
}
So(value.Valid, ShouldBeFalse)
}
})
})