opensource/grafana
1
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-07-31 05:02:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

Tests: Require GrafanaOpts when creating Grafana dir (#97825)

Browse Source 
I don't see a reason to accept a variable amount here, as we never use it. The only use I can see is optionally
including the opts, which isn't necessary and only complicates matters when an empty struct would do just as well: the
options are all created to be assumed zero-values already, in case a test doesn't need that option set.
This commit is contained in:
Mariell Hoversholm
2024-12-12 15:13:06 +01:00
committed by GitHub
parent 47e58d5903
commit e6a6fc6f74
3 changed files with 134 additions and 134 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/cmd/grafana-cli/commands/install_command_test.go
View File

@ -124,7 +124,7 @@ func TestValidatePluginRepoConfig(t *testing.T) {
}
// GrafanaComApiUrl is set to the default path https://grafana.com/api
grafDir, cfgPath := testinfra.CreateGrafDir(t)
grafDir, cfgPath := testinfra.CreateGrafDir(t, testinfra.GrafanaOpts{})
// overriding the GrafanaComApiUrl to https://grafana-dev.com
c, err := commandstest.NewCliContext(map[string]string{